Repository navigation
Skip parameters with an unresolved argument or a conflicting @param doc type - #59
Merged
Merged
Conversation
…oc type
A single literal call site typed the parameter even when other call sites pass
values argtyper cannot resolve, e.g. setCookie($name, '') next to
setCookie('id', $lead->getId()) typed $value as string. An existing @PARAM doc
type naming a union or another type is now respected too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single literal argument was enough to add a type, even when other call sites pass values argtyper cannot resolve. In Mautic this typed
CookieHelper::setCookie($value)asstringbecause of one$this->setCookie($name, '')call, while other callers pass$lead->getId()(anint) - a runtime TypeError.Changes:
@paramdoc type must agree with the resolved type, otherwise the parameter is skipped. Unions (other than withnull) and other types skip, generics/shapes, pseudo types (non-empty-string,positive-int,list, ...), literals andmixedare accepted. Applies to the default-value path tooOn Mautic 8.x this drops added types from 458 to 239 - the removed ones are the unsafe ones.
Not covered: named and variadic arguments are still skipped at collect, so a call using them does not block typing.