Repository navigation
Conversation
PHP takes __halt_compiler/* a */ ( // b ) ; as it takes comments anywhere between tokens. The scanner's halt states took whitespace only and went back to PHP code at a comment, so it lexed the data after the semicolon as code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP accepts comments anywhere between the tokens of
__halt_compiler();:The scanner's halt states take only whitespace there; at a comment they return to PHP code, so the data after the semicolon is lexed as code and fails to parse.
The halt states now lex block, doc and line comments through a
lexer.gohelper, which also records their newlines for token positions.scanner.go, regenerated with ragel 6.10 and gofmt, changes only in those actions. Added scanner tests for the comments and for line numbers after a multi-line one.