Repository navigation
Conversation
The formatter wrote <?php followed by a space and then the newline that starts the code, leaving trailing whitespace on the line. The space is only needed where no whitespace follows the tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatter wrote
<?phpwith a trailing space, followed by the newline that starts the code, which left trailing whitespace on the first line. It now writes<?phpwhere a newline follows. The space stays where nothing else separates the tag from the code.Updated the expected output of three formatter tests. Open PRs #15 and #19 add tests that expect
<?phpwith the space, so whichever of them merges after this one needs those expectations updated.