Skip to content

[dx] Report unnecessary skips in parallel runs too - #8957

Merged
TomasVotruba merged 2 commits into
mainfrom
tv/parallel-unnecessary-skips
Nov 16, 2026
Merged

TomasVotruba merged 2 commits into
mainfrom
tv/parallel-unnecessary-skips

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

Follow-up to #8853.

Why

->reportUnusedSkips() should also report rule-scoped skips that matched a file, but whose rule would not have changed it. This only worked in a single process (--debug or withoutParallel()).

The skipped file paths are recorded in Skipper in the process that handles the files. In a parallel run, that is the workers. The main process then ran NeededSkipVerifier on its own empty Skipper, and silently reported nothing. Parallel is the default, so the report was missing for most users.

What

Send the skipped file paths from the workers to the main process, the same way used_skips already travel:

  • ProcessResult carries skippedFilePathsByRule
  • WorkerCommand sends them under the new Bridge::SKIPPED_FILE_PATHS_BY_RULE key
  • ParallelResultCollector merges and deduplicates them across workers
  • NeededSkipVerifier::verify() reads them from ProcessResult, so single-process and parallel runs share one path

Verified

End-to-end on a sample project with withParallel() + reportUnusedSkips(), one unnecessary and one needed rule-scoped skip:

  • main: no report at all
  • this branch: reports only the unnecessary skip, both in parallel and with --debug

@TomasVotruba
TomasVotruba force-pushed the tv/parallel-unnecessary-skips branch from d31a7d1 to 210fe1c Compare November 16, 2026 21:07
@TomasVotruba
TomasVotruba merged commit 392637a into main Nov 16, 2026
51 checks passed
@TomasVotruba
TomasVotruba deleted the tv/parallel-unnecessary-skips branch November 16, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant