Repository navigation
[dx] Report unnecessary skips in parallel runs too - #8957
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
tv/parallel-unnecessary-skips
branch
from
November 16, 2026 21:07
d31a7d1 to
210fe1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8853.
Why
->reportUnusedSkips()should also report rule-scoped skips that matched a file, but whose rule would not have changed it. This only worked in a single process (--debugorwithoutParallel()).The skipped file paths are recorded in
Skipperin the process that handles the files. In a parallel run, that is the workers. The main process then ranNeededSkipVerifieron its own emptySkipper, and silently reported nothing. Parallel is the default, so the report was missing for most users.What
Send the skipped file paths from the workers to the main process, the same way
used_skipsalready travel:ProcessResultcarriesskippedFilePathsByRuleWorkerCommandsends them under the newBridge::SKIPPED_FILE_PATHS_BY_RULEkeyParallelResultCollectormerges and deduplicates them across workersNeededSkipVerifier::verify()reads them fromProcessResult, so single-process and parallel runs share one pathVerified
End-to-end on a sample project with
withParallel()+reportUnusedSkips(), one unnecessary and one needed rule-scoped skip:main: no report at all--debug