Skip to content

fix(normalizer): Portuguese feminine numbers, signs, percent and currency edge cases (#598) - #600

Merged
remsky merged 2 commits into
masterfrom
fix/portuguese-followups
Nov 13, 2026
Merged

remsky merged 2 commits into
masterfrom
fix/portuguese-followups

Conversation

@remsky

@remsky remsky commented Nov 13, 2026

Copy link
Copy Markdown
Owner

Follow-ups to #553. Closes #598.

  • feminine numbers before hora and libra (2 h reads duas horas, £200 reads duzentas libras), including times (1:30, 22:15)
  • signs are spoken or dropped instead of left behind (-1 h, -0,5, +R$ 5)
  • % reads por cento
  • currency: exact millions take de (um milhão de reais), $1.50 keeps its currency word, malformed amounts (R$ 12,505) fall through to the number pass
  • long decimals keep their digits, huge hour counts are left as digits instead of raising
  • units no longer eat clocks or identifiers (12:30h, abc2h)
  • h-notation times read (12h30, 2h30min, 14h), and a time with letters glued on is left alone (12:30abc)
  • hours read without the units option (14h, 2 h), same as 14:30. other units stay opt-in

Extends the Portuguese flood test to unit and time patterns; updates adding-normalizer skill with the testing and gotchas (pass order, num2words limits, etc).

Testing

  • uv run pytest passes locally (API changes)
  • npm run test:web passes locally (web player changes)
  • New or changed behavior has a test
  • Ran in Docker (npm run cpu:up / gpu:up), for inference or docker changes
  • CHANGELOG.md entry, if users will notice the change

…ency edge cases (#598)

docs(skills): update adding-normalizer skill with additional testing guidance
@remsky remsky linked an issue Nov 13, 2026 that may be closed by this pull request
@remsky
remsky merged commit 3c0d616 into master Nov 13, 2026
8 checks passed
@remsky
remsky deleted the fix/portuguese-followups branch November 13, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Portuguese normalizer follow-up (feminine numbers)

1 participant