Repository navigation
fix(normalizer): Portuguese feminine numbers, signs, percent and currency edge cases (#598) - #600
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #553. Closes #598.
horaandlibra(2 hreadsduas horas,£200readsduzentas libras), including times (1:30,22:15)-1 h,-0,5,+R$ 5)%readspor centode(um milhão de reais),$1.50keeps its currency word, malformed amounts (R$ 12,505) fall through to the number pass12:30h,abc2h)12h30,2h30min,14h), and a time with letters glued on is left alone (12:30abc)14h,2 h), same as14:30. other units stay opt-inExtends the Portuguese flood test to unit and time patterns; updates adding-normalizer skill with the testing and gotchas (pass order, num2words limits, etc).
Testing
uv run pytestpasses locally (API changes)npm run test:webpasses locally (web player changes)npm run cpu:up/gpu:up), for inference or docker changesCHANGELOG.mdentry, if users will notice the change