feat(fetch): add result-based SafeFetch wrapper [Codex] - #367
Draft
jderochervlk wants to merge 3 commits into
Draft
jderochervlk wants to merge 3 commits into
jderochervlk wants to merge 3 commits into
Conversation
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jderochervlk
commented
Sep 22, 2026
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #363
The raw Fetch and Response bindings expose several separate failure channels: request rejection, fulfilled non-OK responses, and body-reader rejection. Applications currently have to reconstruct that distinction while also preserving response metadata and original rejection values.
This adds an opt-in
WebAPI.SafeFetchmodule within the existing Fetch feature. Its request helpers convert synchronous throws and rejected promises intoFetchRejected, classify non-OK responses asResponseNotOk, and retain the native response. Its six body readers share one internal adapter that returns the body with the consumed response or a typed read error with the original cause.The public interface keeps the internal reader helper private, leaves JSON domain decoding to applications, and adds no production dependency. A small internal adapter keeps calls to the raw Fetch bindings distinct from the public wrapper names without changing the raw binding definitions.
Runtime coverage exercises successful requests and init forwarding, non-OK responses, promise rejection, synchronous failure, valid and malformed bodies, already-consumed bodies, readable error bodies, and every exposed reader. The generated API reference documents every public type and function, while the Fetch guide explains the failure stages, raw-response classification, error-body reading, body consumption, and JSON validation boundary.