Repository navigation
Keep a private key for every offered classical key share - #2
Merged
Merged
Conversation
ApplyPreset generated a key for each classical key share but kept only the
first one. When the server selected another offered group (for example P-256
from Firefox's X25519MLKEM768, X25519, P-256), the client failed with
"invalid server key share".
Store the keys after the first in KeySharePrivateKeys.AdditionalEcdhe and pick
the key whose curve matches the server's group.
Based on bogdanfinn/utls 7de494d ("Fix keyshare cycling logic").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ApplyPreset generated a key for each classical key share but kept only the
first one. When the server selected another offered group (for example P-256
from Firefox's X25519MLKEM768, X25519, P-256), the client failed with
"invalid server key share".
Store the keys after the first in KeySharePrivateKeys.AdditionalEcdhe and pick
the key whose curve matches the server's group.
Based on bogdanfinn/utls 7de494d ("Fix keyshare cycling logic").
Stacked on #1 (module path). Merge that first; GitHub then retargets this PR to
master.