Repository navigation
Keep GREASE signature algorithms out of the handshake state - #4
Merged
Merged
Conversation
Chrome 155 sends a GREASE signature algorithm. It belongs on the wire, but writeToUConn also copied it into HandshakeState.Hello, where Go's handshake checks treat it as an offered algorithm. Copy the list without GREASE when one is present; the wire bytes are unchanged. ECH is unaffected because the inner transcript is rebuilt from the outer wire extensions. TestChrome155SignatureGREASESeed asserted the GREASE value in the handshake state; its wire assertion stays, the state one is replaced by TestSignatureAlgorithmGREASEStaysOnTheWire. Based on the writeToUConn part of sardanioss/utls d737ca1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome 155 sends a GREASE signature algorithm. It belongs on the wire, but
writeToUConn also copied it into HandshakeState.Hello, where Go's handshake
checks treat it as an offered algorithm. Copy the list without GREASE when
one is present; the wire bytes are unchanged. ECH is unaffected because the
inner transcript is rebuilt from the outer wire extensions.
TestChrome155SignatureGREASESeed asserted the GREASE value in the handshake
state; its wire assertion stays, the state one is replaced by
TestSignatureAlgorithmGREASEStaysOnTheWire.
Based on the writeToUConn part of sardanioss/utls d737ca1.
Stacked on #1 (module path). Merge that first; GitHub then retargets this PR to
master.