Repository navigation
Match QUICConn's NextEvent and Close in UQUICConn - #5
Merged
Merged
Conversation
Close canceled the handshake but never read signalc, so a handshake blocked waiting for peer data could not observe the cancellation and Close hung forever. NextEvent never reported a failed handshake as QUICErrorEvent. Apply Go's QUICConn versions of both: Close unblocks the handshake goroutine before waiting for it, and NextEvent reports the handshake error once. From MetaCubeX/utls 8853e10 ("keep in sync of UQUICConn and QUICConn").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close canceled the handshake but never read signalc, so a handshake blocked
waiting for peer data could not observe the cancellation and Close hung
forever. NextEvent never reported a failed handshake as QUICErrorEvent.
Apply Go's QUICConn versions of both: Close unblocks the handshake goroutine
before waiting for it, and NextEvent reports the handshake error once.
From MetaCubeX/utls 8853e10 ("keep in sync of UQUICConn and QUICConn").
Stacked on #1 (module path). Merge that first; GitHub then retargets this PR to
master.