Repository navigation
Send the QUIC stack's transport parameters with a preset - #6
Merged
Merged
Conversation
With a preset, UQUICConn ignored SetTransportParameters and sent the parameters baked into the spec, so the ClientHello did not carry the QUIC stack's values such as initial_source_connection_id. QUICTransportParametersExtension gains RawData, a body sent verbatim. On a UQUICConn, writeToUConn fills it from SetTransportParameters, regardless of whether the preset is applied before or after. Without SetTransportParameters the spec's parameters are sent as before. Write makes the extension a TLSExtensionWriter: a captured QUIC ClientHello now parses without blunt mimicry, and the body is kept byte for byte. Based on sardanioss/utls 5d6b871 (SetTransportParameters) and 44b5ea7 (Write).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a preset, UQUICConn ignored SetTransportParameters and sent the
parameters baked into the spec, so the ClientHello did not carry the QUIC
stack's values such as initial_source_connection_id.
QUICTransportParametersExtension gains RawData, a body sent verbatim. On a
UQUICConn, writeToUConn fills it from SetTransportParameters, regardless of
whether the preset is applied before or after. Without SetTransportParameters
the spec's parameters are sent as before.
Write makes the extension a TLSExtensionWriter: a captured QUIC ClientHello
now parses without blunt mimicry, and the body is kept byte for byte.
Based on sardanioss/utls 5d6b871 (SetTransportParameters) and 44b5ea7 (Write).
Stacked on #1 (module path). Merge that first; GitHub then retargets this PR to
master.