Repository navigation
refactor: add #[\Override], make psalm pass without ext-msgpack - #41
Merged
Merged
Conversation
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
chore(psalm): load the msgpack stub and shrink the baseline `MsgpackCodec` is left as is pending the msgpack deprecation decision, so its remaining issues stay in the baseline. The relay port and stream checks are runtime guards for callers without static analysis, hence the inline suppressions. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
roxblnfk
force-pushed
the
static-analysis
branch
from
October 9, 2026 16:11
f91ade3 to
f5ca306
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
src/carries#[\Override], exceptMsgpackCodec, which is left untouched until the msgpack deprecation is decided. On PHP 8.2 the attribute is inert, no polyfill added.resources/stubs/msgpack.phpstub, so it passes withoutext-msgpackinstalled (before, it reportedUndefinedFunctionformsgpack_pack/msgpack_unpacklocally).MsgpackCodecclosure-type entries only:Frame::initFrame()now handles afalsefromunpack(), and the port/stream checks inSocketRelayandStreamRelaycarry inline@psalm-suppress DocblockTypeContradiction— they are runtime guards for callers without static analysis, so removing them would be a behaviour change.final, no signatures changed (ClassMustBeFinalstays disabled inpsalm.xml).Stacked on #40.
Checklist
vendor/bin/psalm(6.19.2) passes locally; also passes with--php-version=8.3