Repository navigation
fix: skip mypy analysis of deprecated 3.x under python 3.11 target - #58
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Causa raiz
deprecated3.0.0 (dependência transitiva) passou a usar statementstypedo Python 3.12. Nos jobs 3.12/3.13 o pip instala essa versão e omypy src/findata(compython_version = "3.11") falha ao parsearsite-packages/deprecated/sphinx.py:35. No 3.11 o pip resolve uma versão antiga, então passa. Isso quebra amaine todo PR (ex.: #57).Correção
Override
follow_imports = "skip"só paradeprecated/deprecated.*.src/não importadeprecated, então a tipagem estrita do nosso código não muda.Validação
origin/mainnum venv 3.12 comdeprecated==3.0.0; com o fix:mypy src/findatasem issues em 3.12 e 3.11;ruff format --checkeruff checklimpos.scripts/ship/preflight.sh: OK.CROSS_FAMILY(autor Claude Opus 5.5, reviewer GPT-6 Astra high via Pi, com tools): sem achados; subirpython_versionenfraqueceria a checagem de 3.11 e pin não é claramente melhor.NOT_APPLICABLE.🤖 Generated with Claude Code