Skip to content

fix: skip mypy analysis of deprecated 3.x under python 3.11 target - #58

Merged
robertoecf merged 1 commit into
mainfrom
claude/mypy-skip-deprecated-stubs
Sep 29, 2026
Merged

robertoecf merged 1 commit into
mainfrom
claude/mypy-skip-deprecated-stubs

Conversation

@robertoecf

Copy link
Copy Markdown
Owner

Causa raiz

deprecated 3.0.0 (dependência transitiva) passou a usar statements type do Python 3.12. Nos jobs 3.12/3.13 o pip instala essa versão e o mypy src/findata (com python_version = "3.11") falha ao parsear site-packages/deprecated/sphinx.py:35. No 3.11 o pip resolve uma versão antiga, então passa. Isso quebra a main e todo PR (ex.: #57).

Correção

Override follow_imports = "skip" só para deprecated/deprecated.*. src/ não importa deprecated, então a tipagem estrita do nosso código não muda.

Validação

  • Reproduzido em origin/main num venv 3.12 com deprecated==3.0.0; com o fix: mypy src/findata sem issues em 3.12 e 3.11; ruff format --check e ruff check limpos.
  • scripts/ship/preflight.sh: OK.
  • Adversarial review CROSS_FAMILY (autor Claude Opus 5.5, reviewer GPT-6 Astra high via Pi, com tools): sem achados; subir python_version enfraqueceria a checagem de 3.11 e pin não é claramente melhor.
  • MCP Trust: NOT_APPLICABLE.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 70729869-17ea-4003-bbd5-7bcc301e746b


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@robertoecf
robertoecf merged commit 9e724f4 into main Sep 29, 2026
8 checks passed
@robertoecf
robertoecf deleted the claude/mypy-skip-deprecated-stubs branch September 29, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant