[Graf] rewrite main ExecuteEvent methods by linev · Pull Request #23484 · root-project/root

linev · 2026-09-24T13:44:10Z

Using new interactive functionality of TPad, one can simplify logic of many ExecuteEvent methods:

remove static variables
remove direct usage of TVirtualPadPainter (XOR operations)

Use TBoxInteractive for more classes, introduce TLineInteractive for several use-cases

Redesign interactivity and painting in TPie class. Fully avoid global and static variables,
do not rely on sequence of calls for ExecuteEvent or DistanceToPrimitive.

Adjust interactivity in THistPainter for zooming - also use new functionality there.

Now all classes in graf2d/graf will use new interactivity logic.

github-actions · 2026-09-25T00:50:01Z

Test Results

24 files 24 suites 4d 0h 6m 24s ⏱️
3 867 tests 3 864 ✅ 0 💤 3 ❌
83 712 runs 83 708 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit b81948f.

♻️ This comment has been updated with latest results.

jblomer

Thanks! LGTM.

silverweed · 2026-09-30T09:11:40Z

+      }
+
+      if (abs(px1 - px) + abs(py1 - py) < kMaxDiff) {
+         selectPoint = 1;


Should use an enum for the bitmask

It is protected member and not leaked outside.
Code will be more tricky if I only can use mask operations.

In GL case do Flush only if there are any reasons for that. And in TPad::IsAnyNeedRepaint() method take into account only new draw actions, stored XOR actions are not relevant for repaint

Instead adding temporary zoombox to list of primitives just draw interactive box on the pad - which can be rectangle or filled box. Use TPad::Interactive to store interim data for that. Tested on all platforms: gVirtualX, GL, Qt6Canvas

Use TPad::Interactive() to store all necessary intermediate values In non-opaque mode use direct gPad painting without complex logic as before. Fully avoid use of static variables now

Use for event handling in TLine and TCurlyLine

Partially reuse logic from TEllipse where similar code is used.

Avoid static methods usage, use new interactive painting

No need to handle XOR operations via painter, just use "i" paint options

Used for XOR painting of pie chart outline during moving. Now TPad method can be used which simplify drawing

Was using global pointers too much, therefore need fully redesign event loop

Use TPad::Interactive and direct TPad::PaintPolyLine with "i" option

To change line attributes in painting one better use TAttLine::ModifyOn() method

Fully avoid usage of global and static variables which are not guarantee to be set correctly. Old functionality was highly depend from call to DistanceToPrimitive. So one cannot be sure if global variables were set correctly. Instead use new `TPad::Interactive()` functionality and store all interim values there.

provide TPie::GetSumOfEntriesValues() method to be able caclualte sum of all entries. It is used in different places for angles caclulations and for printouts

Instead keeping up-to-date internal array of slices angles just calculate it every time when necessary. Simplifies complete logic around events handling and painting of TPie

Implement better TPieSlice::DistanceToPrimitive It returns 0 if wider part of slice is selected Allows to activate context menu for the slice correctly. At the same correctly redirect event execution from TPieSlice to TPie where all sectors/slices handled

Most of calculation are uses this therefore convert to it

There are minimal rounding changes after redesign of TPie

linev requested a review from silverweed September 24, 2026 13:44

linev self-assigned this Sep 24, 2026

linev requested review from couet, guitargeek and hageboeck as code owners September 24, 2026 13:44

linev added the in:Graphics label Sep 24, 2026

linev marked this pull request as draft September 24, 2026 13:44

linev force-pushed the pad_interactive_next branch 2 times, most recently from 776886c to 21bf660 Compare September 28, 2026 14:27

linev changed the title ~~[gpad] rewrite main ExecuteEvent methods~~ [Graf] rewrite main ExecuteEvent methods Sep 28, 2026

linev marked this pull request as ready for review September 28, 2026 14:35

linev force-pushed the pad_interactive_next branch from 21bf660 to 8f5a118 Compare September 28, 2026 14:39

linev requested a review from dpiparo as a code owner September 28, 2026 15:16

jblomer approved these changes Sep 30, 2026

View reviewed changes

silverweed reviewed Sep 30, 2026

View reviewed changes

linev added 14 commits September 30, 2026 18:15

[gpad] adjust new TCanvas::Update() logic

8a26ce2

In GL case do Flush only if there are any reasons for that. And in TPad::IsAnyNeedRepaint() method take into account only new draw actions, stored XOR actions are not relevant for repaint

[histpainter] Use draw actions for TH2 zooming

7863e2c

Instead adding temporary zoombox to list of primitives just draw interactive box on the pad - which can be rectangle or filled box. Use TPad::Interactive to store interim data for that. Tested on all platforms: gVirtualX, GL, Qt6Canvas

[histpainter] change TH1 editing

0692623

Use TPad::Interactive() to store all necessary intermediate values In non-opaque mode use direct gPad painting without complex logic as before. Fully avoid use of static variables now

[graf] introduce TLineInteractive

f7b4617

Use for event handling in TLine and TCurlyLine

[graf] use TBoxInteractive for TCurlyArc

9cb1413

Partially reuse logic from TEllipse where similar code is used.

[graf] use interactive for TText

6263d6c

Avoid static methods usage, use new interactive painting

[graf] simplify TMarker::ExecuteEvent

bddc095

No need to handle XOR operations via painter, just use "i" paint options

[graf] modify TPie::DrawGhost

857d890

Used for XOR painting of pie chart outline during moving. Now TPad method can be used which simplify drawing

[graf] rewrite TPie::ExecuteEvent

f051a1e

Was using global pointers too much, therefore need fully redesign event loop

[graf] modify TPolyLine::ExecuteEvent

37e1831

Use TPad::Interactive and direct TPad::PaintPolyLine with "i" option

[graf] do not use pad painter in TArrow

3fbee9a

To change line attributes in painting one better use TAttLine::ModifyOn() method

[graf] mark most TPie getters const,

f12033c

provide TPie::GetSumOfEntriesValues() method to be able caclualte sum of all entries. It is used in different places for angles caclulations and for printouts

[graf] redesign TPie angles managment

f3902b6

Instead keeping up-to-date internal array of slices angles just calculate it every time when necessary. Simplifies complete logic around events handling and painting of TPie

linev added 3 commits September 30, 2026 18:18

[graf] fix TPie event handling

ab73e1c

Implement better TPieSlice::DistanceToPrimitive It returns 0 if wider part of slice is selected Allows to activate context menu for the slice correctly. At the same correctly redirect event execution from TPieSlice to TPie where all sectors/slices handled

[graf] use radians for angles in TPie

904cd64

Most of calculation are uses this therefore convert to it

[graf] change svg_ref/piechart.svg

b81948f

There are minimal rounding changes after redesign of TPie

linev force-pushed the pad_interactive_next branch from 0db264f to b81948f Compare September 30, 2026 16:21

Navigation Menu

[Graf] rewrite main ExecuteEvent methods - #23484

[Graf] rewrite main ExecuteEvent methods#23484
linev wants to merge 17 commits into
root-project:masterfrom
linev:pad_interactive_next

linev commented Sep 24, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 25, 2026 •

edited

Loading

Uh oh!

jblomer left a comment

Uh oh!

Uh oh!

silverweed Sep 30, 2026

Uh oh!

linev Sep 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

linev commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

jblomer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

silverweed Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

linev Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

linev commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 25, 2026 •

edited

Loading