Conversation
- Add macos-15-intel to the matrix so x86_64 macOS is built alongside macos-latest (arm64), and set fail-fast: false so one failing platform does not cancel the others. - Install Python with actions/setup-python on macOS: brew install python@3.12 fails to link on Intel runners, which ship a python.org framework in /usr/local/bin. Get setuptools and Cython from pip. - Derive LDFLAGS/CPPFLAGS from brew --prefix instead of hard-coding /usr/local, which does not exist on Apple silicon. - Locate libasan.so with gcc -print-file-name instead of a gcc 11 path, which is missing on current ubuntu-latest so the preload was ignored. - Bump actions/checkout to v7 (v3 runs on the deprecated Node 20).
pnavais
force-pushed
the
ci/update-workflow
branch
from
September 30, 2026 20:14
4e1f632 to
36c1a2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
.github/workflows/c-cpp.ymlto cover Intel macOS and fixes a few problems in the existing macOS and Ubuntu setup.Changes:
macos-15-intelto the matrix.macos-latestonly runs on Apple silicon, so x86_64 macOS was never built.fail-fast: false: a failure on one platform no longer cancels the others. Currently a macOS failure cancels both Windows jobs.actions/setup-pythonand getsetuptoolsand Cython from pip.brew install python@3.12fails at the link step on Intel runners, because the image ships a python.org framework in/usr/local/bin.LDFLAGS/CPPFLAGSfrom$(brew --prefix). The hard-coded/usr/local/optdoes not exist on Apple silicon (/opt/homebrew).libasan.sowithgcc -print-file-name. The hard-coded gcc 11 path no longer exists onubuntu-latest, so the preload was silently ignored (ERROR: ld.so: object '/usr/lib/gcc/x86_64-linux-gnu/11/libasan.so' from LD_PRELOAD cannot be preloaded).actions/checkout: bump v3 → v7 (v3 runs on the deprecated Node 20).Depends on #81. On current
master, both macOS jobs fail withCharset WINDOWS-874 already exists and is not CP874, which is the bug #81 fixes. So this PR's macOS checks will be red until #81 is merged.Test runs in my fork:
master: macOS arm64 and x86_64 fail with the WINDOWS-874 error; Ubuntu and Windows pass.