Skip to content

Compact obj_free candidates in place #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eightbitraptor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Compact obj_free candidates in place #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions gc/mmtk/src/weak_proc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,21 +133,17 @@ impl WeakProcessor {
}

fn process_obj_free_candidates(obj_free_candidates: &mut Vec<ObjectReference>) {
// Process obj_free
let mut new_candidates = Vec::new();

for object in obj_free_candidates.iter().copied() {
obj_free_candidates.retain_mut(|object| {
if object.is_reachable() {
// Forward and add back to the candidate list.
let new_object = object.forward();
trace!("Forwarding obj_free candidate: {object} -> {new_object}");
new_candidates.push(new_object);
*object = new_object;
true
} else {
upcalls::call_obj_free(object);
upcalls::call_obj_free(*object);
false
}
}

*obj_free_candidates = new_candidates;
});
}

struct ProcessParallelObjFreeCandidates {
Expand Down
Loading