Conversation
Clarify how they (do not) interact with read buffers. SSLSocket#pending corresponds to SSL_pending(). It reports data that is already processed and is immediately available to read from the OpenSSL library's internal buffer. SSLSocket#wait_readable does not check for buffered data, either in the OpenSSL library or in OpenSSL::Buffering, so it may block even when data is already available to read. This is different from IO#wait_readable. I considered changing SSLSocket#wait_readable to check these buffers, but rejected it because it is also used when the caller specifically needs to wait for new records from the peer, particularly after SSLSocket#write_nonblock returns :wait_readable.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify how they (do not) interact with read buffers.
SSLSocket#pendingcorresponds toSSL_pending(). It reports data that is already processed and is immediately available to read from the OpenSSL library's internal buffer.SSLSocket#wait_readabledoes not check for buffered data, either in the OpenSSL library or inOpenSSL::Buffering, so it may block even when data is already available to read.This is different from
IO#wait_readable. I considered changingSSLSocket#wait_readableto check these buffers, but rejected it because it is also used when the caller specifically needs to wait for new records from the peer, particularly afterSSLSocket#write_nonblockreturns:wait_readable.