Repository navigation
fix: omit empty owner on JSON import (#22) - #23
Merged
Merged
Conversation
… errors Fixes #22 Halo draftPost() only fills the current user when owner is null/absent. Setting owner to '' left posts with an empty owner, so PostReconciler failed Subscription validation and imported drafts stayed invisible.
Empty string was kept by Halo draftPost() and broke Subscription validation. delete leaves owner absent so the current user is filled. Fixes #22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #22.
JSON ZIP import set
post.spec.ownerto an empty string inpreparePostRequestForImport(). Halo'sdraftPost()only fills the current user whenowneris null/absent, so the empty string was kept.PostReconcilerthen failedSubscriptionvalidation (subscriber name must be non-empty), imported drafts stayed invisible, and publish-after-import could hit HTTP 504.Change
owner = ''during JSON import prep, matching Markdown/Word import which omitownerso Halo assigns the current user.Why this is small-scope
One-line behavioral fix in a single UI helper; no API/schema or broader import redesign.
Test plan