Repository navigation
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @marioidival (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
sorry but i think having llm generated documentation is unacceptable, we had bad stories in past about it, and i would be glad if we don't repeat ours mistakes from past |
Author
|
Understood. This PR was prepared with LLM assistance. I will not submit further automated documentation contributions to this repository. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1956.
The DSL example uses
stringify!{$e}without explaining why it has braces. Add a short note that the parenthesized and bracketed forms have the same effect here, and thatcalculate!accepts any of the three delimiter pairs regardless of its matcher. Also mention the trailing semicolon needed for parenthesized or bracketed statement invocations. The runnable example is unchanged.Validation:
mdbook test(197 chapters), the original example compiled and run, English/Japanese/Chinese/Spanish/Korean builds, and the official full-tree linkchecker for all five builds. Separately compiled threestringify!variants and six statement-delimiter/semicolon cases to verify the explanation against actual behavior, including the two expected syntax errors.The wording follows the Rust Reference's macro invocation syntax and outer matcher delimiter rule.
AI assistance: Authored and validated with OpenAI Codex in a user-authorized contribution automation.