Repository navigation
Remove rustc_legacy_const_generics from unstable intrinsics - #2254
Open
TechnoPorg wants to merge 2 commits into
Open
TechnoPorg wants to merge 2 commits into
TechnoPorg wants to merge 2 commits into
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @sayantn (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Why was this reviewer chosen?The reviewer was selected based on:
|
TechnoPorg
commented
Oct 12, 2026
Comment on lines
+192
to
+196
| // Some of the functions extracted from mips-msa.h have immediate arguments between non-immediate arguments, | ||
| // but Rust const generics are not function arguments and cannot be expressed in a way that matches the header. | ||
| // For the sake of verification, rust const generics are treated as "the last arguments to a function". | ||
| arg_tys.sort_by(|arg1, arg2| arg1.is_const().cmp(&arg2.is_const())); | ||
|
|
Author
There was a problem hiding this comment.
This feels gross, but then again, so does having const arguments in the middle of other non-const arguments 🤷♀️
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in rust-lang/rust#149654 and #2248 (comment), intrinsics using this feature should not be stabilized. Since none of these architectures have stable intrinsics yet (unlike x86{_64}, ARM, WASM, and AArch64, which are excluded from this PR),
rustc_legacy_const_genericscan be removed without creating inconsistencies.LoongArch has also not been touched here as it appears to be handled in #2221.