[Jamesbarford]

We're missing a $;

export CFLAGS="<...> --sysroot=${AARCH64_...
                               ^

[rustbot]

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: @Amanieu, @adamgemmell, @davidtwco, @folkertdev
• @Amanieu, @adamgemmell, @davidtwco, @folkertdev expanded to Amanieu, adamgemmell, davidtwco, folkertdev
• Random selection from Amanieu, adamgemmell, davidtwco, folkertdev

[folkertdev]

Interesting, what did this break before?

View changes since this review

[Jamesbarford]

Interesting, what did this break before?

View changes since this review

I'm not entirely sure if broke anything in this repo, I spotted it while working on the other PR and it didn't look right.

[adamgemmell]

Codex's trace on why the CI happens to still work, if it's interesting:

It broke the C compiler’s sysroot setting for big-endian AArch64, but the rest of the setup masks it.

The shell passes --sysroot={AARCH64_BE_TOOLCHAIN}/... literally. That names a nonexistent relative directory; the compiler doesn’t reject it immediately.

It still works because:

• The preceding -I${AARCH64_BE_TOOLCHAIN}/.../usr/include expands correctly and supplies the libc headers.

• The C wrappers are compiled into a static library by cc::Build (crates/intrinsic-test/src/common/gen_rust.rs:384), so this step doesn’t need sysroot libraries or startup files.

• Rust performs the final link using the separately configured cross-GCC linker (ci/docker/aarch64_be-unknown-linux-gnu/Dockerfile:32), which has its own toolchain configuration. CFLAGS doesn’t control that link.

So this leaves a broken fallback header/library search path, rather than disabling the intrinsic tests. It could fail if compilation needed headers outside the explicit include directory, or if these flags were used for C linking.