Repository navigation
fix(W-19883639): Upgrade TypeScript & eslint and configure trusted publishing - #524
Merged
Merged
Conversation
| */ | ||
|
|
||
| /* eslint-disable no-console, class-methods-use-this */ | ||
| /* eslint-disable no-console */ |
Contributor
There was a problem hiding this comment.
are they console.loging somewhere in here? this rule is disabled in other src/ files, would be good to remove and ensure no console.log
Contributor
Author
There was a problem hiding this comment.
I'll check, thanks. I was trying to change as little as possible.
Contributor
Author
There was a problem hiding this comment.
They are console.log statements that, it looks like, are being used instead of ux.log statements. I'm not keen on changing this as part of this PR, but we could create a separate ticket for the work.
WillieRuemmele
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
@W-19883639@
Functionality Before
Functionality After
There should be no change to existing functionality.