Repository navigation
chore(deps): update dependency golangci/golangci-lint to v2.14.0 - #92
Conversation
Dependency Bump EvaluationVersion change: golangci/golangci-lint v2.4.0 to v2.14.0 (minor, spanning 10 minor releases) Changes:
Breaking changes: None affecting this codebase. The linter has config-level changes across these releases (exhaustruct deprecated for exhaustruct_v5, revive var-naming package checks moved to package-naming, gofumpt config restructured), but these are all addressed in the Security concerns: None. golangci-lint is a development-time linter, not a runtime dependency. No production code paths are affected. Impact on codebase: All Go source changes are purely mechanical and behavior-preserving - string constant extraction and slice preallocation patterns. The runtime semantics of every modified function remain identical. CI status: All checks passing (golangci-lint, tests, build-e2e, detect-modules) Recommendation: SAFE TO MERGE Notes:
--- Claude Code |
4019128 to
4904ae0
Compare
4904ae0 to
9189316
Compare
ezekiel-alexrod
left a comment
There was a problem hiding this comment.
LGTM. Not for this PR, but I think .golangci.yml needs a follow-up:
issues.fix: truehides findings. With it, the 2wslissues inlogicalvolumegetter/ssacli.go:225andphysicaldrivegetter/ssacli.go:299are not reported and no file is changed, so CI says0 issues. With--fix=falsethey come back. It's already the case onmain. I'd removefix: trueand let people run--fixlocally.wslis deprecated, golangci-lint suggestswsl_v5. Same for gofumptextra-rules, replaced byextra.group-params.
…2.14.0 - extract repeated CLI arguments (mdadm, ssacli, lsblk, storcli) into constants - build argument slices in a single append instead of append-after-literal
- Remove issues.fix: golangci-lint fixed findings in place during the run, so CI reported 0 issues while they existed on the checked-out code. Run golangci-lint run --fix locally instead. - Replace the deprecated wsl linter by wsl_v5, and gofumpt extra-rules by extra.group-params.
d84129d to
b34f7ec
Compare
|
Thanks for the review. I rebased the branch on
With golangci-lint 2.14.0 locally, |
This PR contains the following updates:
v2.4.0→v2.14.0Release Notes
golangci/golangci-lint (golangci/golangci-lint)
v2.14.0Compare Source
Released on 2026-09-24
bodyclose: from73d1f95to857993a(new directivehandled)exhaustive: from 0.12.0 to 0.13.0exhaustruct_v5: from 5.0.3 to 5.2.0 (new option:allow-empty-blank-assignments)go-check-sumtype: from 0.3.1 toae6904dgocritic: from 0.14.4 to 0.15.0gofumpt: from 0.11.0 to 0.12.0gomoddirectives: from 0.9.0 to 0.10.0gosec: from 2.28.0 to 2.29.0 (re-enableG407)govet-modernize: from 0.49.0 to 0.50.0loggercheck: from 0.11.0 to 0.12.0revive: from 1.15.0 to 1.17.0 (new rules:marshal-receiver,multiline-if-init,use-slices-concat)tagliatelle: from 0.7.2 to 0.8.0fatcontext: from 0.10.0 to 0.10.1flock: from 0.13.0 to 0.13.1godoclint: from 0.11.2 to 0.11.4protogetter: from 0.3.21 to 1.0.1recvcheck: from 0.3.0 to 0.3.1tagalign: from 1.4.3 to 1.4.4v2.13.2Compare Source
Released on 2026-08-28
iface: from 1.5.0 to 1.5.1staticcheck: from 0.8.0 to 0.8.1unparam: from3f964bcto2fa3d84canonicalheader: from v1.1.2 to a temporary forkv2.13.1Compare Source
Released on 2026-08-20
ginkgolinter: from 0.23.1 to 0.24.0gofmt: fromd62b90etoe84e050staticcheck: from 0.8.0-rc.1 to 0.8.0wsl_v5: from 5.8.0 to 5.9.0v2.13.0Compare Source
Released on 2026-08-19
dupword: from 0.1.7 to 0.1.8 (new optionskip-raw-strings)errcheck: from 1.10.0 to 1.20.0exhaustruct_v5: from 4.0.0 to 5.0.2 (new configuration)exhaustruct: deprecated and replaced byexhaustruct_v5fatcontext: from 0.9.0 to 0.10.0 (new options:check-loops,check-function-literals)goconst: from 1.10.0 to 1.11.0 (new options:ignore-map-keys,exclude-types)gofumpt: from 0.9.2 to 0.11.0 (new options:extra.group-params,extra.clothe-returns,extra.balance-calls)gomoddirectives: from 0.8.0 to 0.9.0 (new option:replace-allow-all)gosec: from 2.26.1 to 2.27.1govet-modernize: from 0.44.0 to 0.49.0 (fmtappendfis removed. New analyzersatomictypes,embedlit,errorsastype,importcomment,reflecttypeassert,slicesclip, andslicesbackward.waitgroupis renamedwaitgroupgo)iface: from 1.4.3 to 1.5.0 (new analyzer:unusedmethod)noinlineerr: from 1.0.5 to 1.0.6nonamedreturns: from 1.0.6 to 1.0.8 (new option:allow-unused-named-returns)recvcheck: from 0.2.0 to 0.3.0 (new default exclusions)unparam: from5beb8c8to3f964bcclickhouse-go-linter: from 1.2.0 to 1.2.1errname: from 1.1.1 to 1.1.2exhaustruct_v5: from 5.0.2 to 5.0.3funcorder: add missingFunctionfieldginkgolinter: from 0.23.0 to 0.23.1gocheckcompilerdirectives: from 1.3.0 to 1.4.0gocritic: from 0.14.3 to 0.14.4gomoddirectives: add missingIgnoreForbiddenfieldiface: from 1.4.2 to 1.4.3mirror: from 1.3.0 to 1.3.3nilnil: from 1.1.1 to 1.1.2protogetter: from 0.3.20 to 0.3.21v2.12.2Compare Source
Released on 2026-05-06
gomodguard_v2: fix blocked configurationgomodguard_v2: from 2.1.0 to 2.1.3iface: from 1.4.1 to 1.4.2v2.12.1Compare Source
Released on 2026-05-01
gomodguard_v2: fix panic with migration suggestioninstall.shscript (if you are still using an URL based on the branchmaster, please update to usehttps://golangci-lint.run/install.sh)v2.12.0Compare Source
Released on 2026-05-01
clickhouselintlinter https://github.com/ClickHouse/clickhouse-go-linterdupl: fromf665c8dtoc99c5cf(extended detection)funcorder: from 0.5.0 to 0.6.0 (new option:function)goconst: add an option to ignore strings from testsgoconst: from 1.8.2 to 1.10.0 (extended detection)gomodguard_v2: from 1.4.1 to 2.1.0 (major version with new configuration)gosec: from619ce21to 2.28.0 (new checks:G124,G708,G709,G710)govet: addinlineanalyzermakezero: from 2.1.0 to 2.2.1 (support slice type aliases)paralleltest: exposecheckcleanupoptionsloglint: from 0.11.1 to 0.12.0 (new options:allowed-keys,custom-funcs)wsl_v5: from 5.6.0 to 5.8.0 (new option:cuddle-max-statements; new checks:after-decl,after-defer,after-expr,after-go,cuddle-group)forbidigo: from 2.3.0 to 2.3.1godot: from 1.5.4 to 1.5.6govet-modernize: from 0.43.0 to 0.44.0ireturn: from 0.4.0 to 0.4.1rowserrcheck: from 1.1.1 toc5f79b8customcommandv2.11.4Compare Source
Released on 2026-03-22
govet-modernize: from 0.42.0 to 0.43.0noctx: from 0.5.0 to 0.5.1sqlclosecheck: from 0.5.1 to 0.6.0v2.11.3Compare Source
Released on 2026-03-10
gosec: from v2.24.7 to619ce21v2.11.2Compare Source
Released on 2026-03-07
fmt: fix error when using thefmtcommand with explicit paths.v2.11.1Compare Source
Released on 2026-03-06
Due to an error related to AUR, some artifacts of the v2.11.0 release have not been published.
This release contains the same things as v2.11.0.
v2.11.0Compare Source
Released on 2026-03-06
errcheck: from 1.9.0 to 1.10.0 (excludecrypto/rand.Readby default)gosec: from 2.23.0 to 2.24.6 (new rules:G113,G118,G119,G120,G121,G122,G123,G408,G707)noctx: from 0.4.0 to 0.5.0 (new detection:httptest.NewRequestWithContext)prealloc: from 1.0.2 to 1.1.0revive: from 1.14.0 to 1.15.0 (var-namingto a new rulepackage-naming)gocognit: from 1.2.0 to 1.2.1gosec: from 2.24.6 to 2.24.7unqueryvet: from 1.5.3 to 1.5.4v2.10.1Compare Source
Released on 2026-02-17
v2.10.0Compare Source
Released on 2026-02-17
ginkgolinter: from 0.22.0 to 0.23.0gosec: from 2.22.11 to 2.23.0 (new rules:G117,G602,G701,G702,G703,G704,G705,G706)staticcheck: from 0.6.1 to 0.7.0godoclint: from 0.11.1 to 0.11.2v2.9.0Compare Source
Released on 2026-02-10
arangolint: from 0.3.1 to 0.4.0 (new rule: detect potential query injections)ginkgolinter: from 0.21.2 to 0.22.0 (support for wrappers)golines: from 0.14.0 to 0.15.0misspell: from 0.7.0 to 0.8.0revive: from v1.13.0 to v1.14.0 (new rules:epoch-naming,use-slices-sort)unqueryvet: from 1.4.0 to 1.5.3 (new options:check-n1,check-sql-injection,check-tx-leaks,allow,custom-rules)wsl_v5: from 5.3.0 to 5.6.0 (new rule:after-block)modernize: from 0.41.0 to 0.42.0prealloc: from 1.0.1 to 1.0.2protogetter: from 0.3.18 to 0.3.20v2.8.0Compare Source
Released on 2026-01-07
godoclint: from 0.10.2 to 0.11.1 (new rule:require-stdlib-doclink)golines: from442fd00to 0.14.0gomoddirectives: from 0.7.1 to 0.8.0gosec: fromdaccba6to 2.22.11 (new rule:G116)modernize: from 0.39.0 to 0.40.0 (new analyzers:stringscut,unsafefuncs)prealloc: from 1.0.0 to 1.0.1 (message changes)unqueryvet: from 1.3.0 to 1.4.0 (new options:check-aliased-wildcard,check-string-concat,check-format-strings,check-string-builder,check-subqueries,ignored-functions,sql-builders)gocritic: from 0.14.2 to 0.14.3errorlint: from 1.8.0 to 1.9.0govet: from 0.39.0 to 0.40.0protogetter: from 0.3.17 to 0.3.18revive: add missing enable-default-rules settingv2.7.2Compare Source
Released on 2025-12-07
gosec: from 2.22.10 todaccba6v2.7.1Compare Source
Released on 2025-12-04
modernize: disablestringscutanalyzerv2.7.0Compare Source
Released on 2025-12-03
customcommandnosprintfhostport: from 0.2.0 to 0.3.1 (ignore string literals without a colon)unqueryvet: from 1.2.1 to 1.3.0 (handlesconstandvardeclarations)revive: from 1.12.0 to 1.13.0 (new option:enable-default-rules, new rules:forbidden-call-in-wg-go,unnecessary-if,inefficient-map-lookup)modernize: from 0.38.0 to 0.39.0 (new analyzers:plusbuild,stringscut)perfsprint: from 0.10.0 to 0.10.1wrapcheck: from 2.11.0 to 2.12.0godoclint: from 0.10.1 to 0.10.2customcommandv2.6.2Compare Source
Released on 2025-11-14
fmtcommand with symlinkstestableexamples: from 1.0.0 to 1.0.1testpackage: from 1.1.1 to 1.1.2v2.6.1Compare Source
Released on 2025-11-04
copyloopvar: from 1.2.1 to 1.2.2gocritic: from 0.14.0 to 0.14.2v2.6.0Compare Source
Released on 2025-10-29
modernizeanalyzer suitearangolint: from 0.2.0 to 0.3.1dupword: from 0.1.6 to 0.1.7 (new optioncomments-only)gocritic: from 0.13.0 to 0.14.0 (new rules/checkers:zeroByteRepeat,dupOption)gofumpt: from 0.9.1 to 0.9.2 ("clothe" naked returns is now controlled by theextra-rulesoption)perfsprint: from 0.9.1 to 0.10.0 (new options:concat-loop,loop-other-ops)wsl: from 5.2.0 to 5.3.0dupword: from 0.1.6 to 0.1.7durationcheck: from 0.0.10 to 0.0.11exptostd: from 0.4.4 to 0.4.5fatcontext: from 0.8.1 to 0.9.0forbidigo: from 2.1.0 to 2.3.0ginkgolinter: from 0.21.0 to 0.21.2godoclint: from 0.10.0 to 0.10.1gomoddirectives: from 0.7.0 to 0.7.1gosec: from 2.22.8 to 2.22.10makezero: from 2.0.1 to 2.1.0nilerr: from 0.1.1 to 0.1.2paralleltest: from 1.0.14 to 1.0.15protogetter: from 0.3.16 to 0.3.17unparam: from0df0534to5beb8c8v2.5.0Compare Source
Released on 2025-09-21
godoclintlinter https://github.com/godoc-lint/godoc-lintunqueryvetlinter https://github.com/MirrexOne/unqueryvetiotamixinglinter https://github.com/AdminBenni/iota-mixingembeddedstructfieldcheck: from 0.3.0 to 0.4.0 (new option:empty-line)err113: fromaea10b5to 0.1.1 (skip internals ofIsmethods forerrortype)ginkgolinter: from 0.20.0 to 0.21.0 (new option:force-tonot)gofumpt: from 0.8.0 to 0.9.1 (new rule is to "clothe" naked returns for the sake of clarity)ineffassign: from 0.1.0 to 0.2.0 (new option:check-escaping-errors)musttag: from 0.13.1 to 0.14.0 (support interface methods)revive: from 1.11.0 to 1.12.0 (new options:identical-ifelseif-branches,identical-ifelseif-conditions,identical-switch-branches,identical-switch-conditions,package-directory-mismatch,unsecure-url-scheme,use-waitgroup-go,useless-fallthrough)thelper: from 0.6.3 to 0.7.1 (skipt.Helperin functions passed tosynctest.Test)wsl_v5: from 5.1.1 to 5.2.0 (improvements related to subexpressions)asciicheck: from 0.4.1 to 0.5.0errname: from 1.1.0 to 1.1.1fatcontext: from 0.8.0 to 0.8.1goprintffuncname: from 0.1.0 to 0.1.1godot: from 1.5.1 to 1.5.4gosec: from 2.22.7 to 2.22.8nilerr: from 0.1.1 to a temporary forknilnil: from 1.1.0 to 1.1.1protogetter: from 0.3.15 to 0.3.16tagliatelle: from 0.7.1 to 0.7.2testifylint: from 1.6.1 to 1.6.4Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.