Skip to content

chore(deps): update dependency golangci/golangci-lint to v2.14.0 - #92

Merged
g-carre merged 3 commits into
mainfrom
renovate/golangci-golangci-lint-2.x
Oct 9, 2026
Merged

g-carre merged 3 commits into
mainfrom
renovate/golangci-golangci-lint-2.x

Conversation

@scality-renovate

@scality-renovate scality-renovate Bot commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Update Change
golangci/golangci-lint minor v2.4.0 → v2.14.0

Release Notes

golangci/golangci-lint (golangci/golangci-lint)

v2.14.0

Compare Source

Released on 2026-09-24

  1. Bug fixes
    • fix: cache of facts reloading
  2. Linters new features or changes
    • bodyclose: from 73d1f95 to 857993a (new directive handled)
    • exhaustive: from 0.12.0 to 0.13.0
    • exhaustruct_v5: from 5.0.3 to 5.2.0 (new option: allow-empty-blank-assignments)
    • go-check-sumtype: from 0.3.1 to ae6904d
    • gocritic: from 0.14.4 to 0.15.0
    • gofumpt: from 0.11.0 to 0.12.0
    • gomoddirectives: from 0.9.0 to 0.10.0
    • gosec: from 2.28.0 to 2.29.0 (re-enable G407)
    • govet-modernize: from 0.49.0 to 0.50.0
    • loggercheck: from 0.11.0 to 0.12.0
    • revive: from 1.15.0 to 1.17.0 (new rules: marshal-receiver, multiline-if-init, use-slices-concat)
    • tagliatelle: from 0.7.2 to 0.8.0
  3. Linters bug fixes
    • fatcontext: from 0.10.0 to 0.10.1
    • flock: from 0.13.0 to 0.13.1
    • godoclint: from 0.11.2 to 0.11.4
    • protogetter: from 0.3.21 to 1.0.1
    • recvcheck: from 0.3.0 to 0.3.1
    • tagalign: from 1.4.3 to 1.4.4

v2.13.2

Compare Source

Released on 2026-08-28

  1. Bug fixes
    • Decrease cache entropy
  2. Linters bug fixes
    • iface: from 1.5.0 to 1.5.1
    • staticcheck: from 0.8.0 to 0.8.1
    • unparam: from 3f964bc to 2fa3d84
    • canonicalheader: from v1.1.2 to a temporary fork

v2.13.1

Compare Source

Released on 2026-08-20

  1. Linters bug fixes
    • ginkgolinter: from 0.23.1 to 0.24.0
    • gofmt: from d62b90e to e84e050
    • staticcheck: from 0.8.0-rc.1 to 0.8.0
    • wsl_v5: from 5.8.0 to 5.9.0

v2.13.0

Compare Source

Released on 2026-08-19

  1. Enhancements
    • 🎉 go1.27 support
  2. Bug fixes
    • fix: cache package facts
  3. Linters new features or changes
    • dupword: from 0.1.7 to 0.1.8 (new option skip-raw-strings)
    • errcheck: from 1.10.0 to 1.20.0
    • exhaustruct_v5: from 4.0.0 to 5.0.2 (new configuration)
    • exhaustruct: deprecated and replaced by exhaustruct_v5
    • fatcontext: from 0.9.0 to 0.10.0 (new options: check-loops, check-function-literals)
    • goconst: from 1.10.0 to 1.11.0 (new options: ignore-map-keys, exclude-types)
    • gofumpt: from 0.9.2 to 0.11.0 (new options: extra.group-params, extra.clothe-returns, extra.balance-calls)
    • gomoddirectives: from 0.8.0 to 0.9.0 (new option: replace-allow-all)
    • gosec: from 2.26.1 to 2.27.1
    • govet-modernize: from 0.44.0 to 0.49.0 (fmtappendf is removed. New analyzers atomictypes, embedlit, errorsastype, importcomment, reflecttypeassert, slicesclip, and slicesbackward. waitgroup is renamed waitgroupgo)
    • iface: from 1.4.3 to 1.5.0 (new analyzer: unusedmethod)
    • noinlineerr: from 1.0.5 to 1.0.6
    • nonamedreturns: from 1.0.6 to 1.0.8 (new option: allow-unused-named-returns)
    • recvcheck: from 0.2.0 to 0.3.0 (new default exclusions)
    • unparam: from 5beb8c8 to 3f964bc
  4. Linters bug fixes
    • clickhouse-go-linter: from 1.2.0 to 1.2.1
    • errname: from 1.1.1 to 1.1.2
    • exhaustruct_v5: from 5.0.2 to 5.0.3
    • funcorder: add missing Function field
    • ginkgolinter: from 0.23.0 to 0.23.1
    • gocheckcompilerdirectives: from 1.3.0 to 1.4.0
    • gocritic: from 0.14.3 to 0.14.4
    • gomoddirectives: add missing IgnoreForbidden field
    • iface: from 1.4.2 to 1.4.3
    • mirror: from 1.3.0 to 1.3.3
    • nilnil: from 1.1.1 to 1.1.2
    • protogetter: from 0.3.20 to 0.3.21

v2.12.2

Compare Source

Released on 2026-05-06

  1. Linters bug fixes
    • gomodguard_v2: fix blocked configuration
    • gomodguard_v2: from 2.1.0 to 2.1.3
    • iface: from 1.4.1 to 1.4.2

v2.12.1

Compare Source

Released on 2026-05-01

  1. Linters bug fixes
    • gomodguard_v2: fix panic with migration suggestion
  2. Misc.
    • fix install.sh script (if you are still using an URL based on the branch master, please update to use https://golangci-lint.run/install.sh)

v2.12.0

Compare Source

Released on 2026-05-01

  1. New linters
  2. Linters new features or changes
    • dupl: from f665c8d to c99c5cf (extended detection)
    • funcorder: from 0.5.0 to 0.6.0 (new option: function)
    • goconst: add an option to ignore strings from tests
    • goconst: from 1.8.2 to 1.10.0 (extended detection)
    • gomodguard_v2: from 1.4.1 to 2.1.0 (major version with new configuration)
    • gosec: from 619ce21 to 2.28.0 (new checks: G124, G708, G709, G710)
    • govet: add inline analyzer
    • makezero: from 2.1.0 to 2.2.1 (support slice type aliases)
    • paralleltest: expose checkcleanup option
    • sloglint: from 0.11.1 to 0.12.0 (new options: allowed-keys, custom-funcs)
    • wsl_v5: from 5.6.0 to 5.8.0 (new option: cuddle-max-statements; new checks: after-decl, after-defer, after-expr, after-go, cuddle-group)
  3. Linters bug fixes
    • forbidigo: from 2.3.0 to 2.3.1
    • godot: from 1.5.4 to 1.5.6
    • govet-modernize: from 0.43.0 to 0.44.0
    • ireturn: from 0.4.0 to 0.4.1
    • rowserrcheck: from 1.1.1 to c5f79b8
  4. Misc.
    • Decrease cache entropy
    • Embed the JSON schema in the binary
    • Filter env vars when cloning the repository with the custom command

v2.11.4

Compare Source

Released on 2026-03-22

  1. Linters bug fixes
    • govet-modernize: from 0.42.0 to 0.43.0
    • noctx: from 0.5.0 to 0.5.1
    • sqlclosecheck: from 0.5.1 to 0.6.0

v2.11.3

Compare Source

Released on 2026-03-10

  1. Linters bug fixes

v2.11.2

Compare Source

Released on 2026-03-07

  1. Fixes
    • fmt: fix error when using the fmt command with explicit paths.

v2.11.1

Compare Source

Released on 2026-03-06

Due to an error related to AUR, some artifacts of the v2.11.0 release have not been published.

This release contains the same things as v2.11.0.

v2.11.0

Compare Source

Released on 2026-03-06

  1. Linters new features or changes
    • errcheck: from 1.9.0 to 1.10.0 (exclude crypto/rand.Read by default)
    • gosec: from 2.23.0 to 2.24.6 (new rules: G113, G118, G119, G120, G121, G122, G123, G408, G707)
    • noctx: from 0.4.0 to 0.5.0 (new detection: httptest.NewRequestWithContext)
    • prealloc: from 1.0.2 to 1.1.0
    • revive: from 1.14.0 to 1.15.0 (⚠️ Breaking change: package-related checks moved from var-naming to a new rule package-naming)
  2. Linters bug fixes
    • gocognit: from 1.2.0 to 1.2.1
    • gosec: from 2.24.6 to 2.24.7
    • unqueryvet: from 1.5.3 to 1.5.4

v2.10.1

Compare Source

Released on 2026-02-17

  1. Fixes
    • buildssa panic

v2.10.0

Compare Source

Released on 2026-02-17

  1. Linters new features or changes
    • ginkgolinter: from 0.22.0 to 0.23.0
    • gosec: from 2.22.11 to 2.23.0 (new rules: G117, G602, G701, G702, G703, G704, G705, G706)
    • staticcheck: from 0.6.1 to 0.7.0
  2. Linters bug fixes
    • godoclint: from 0.11.1 to 0.11.2

v2.9.0

Compare Source

Released on 2026-02-10

  1. Enhancements
    • 🎉 go1.26 support
  2. Linters new features or changes
    • arangolint: from 0.3.1 to 0.4.0 (new rule: detect potential query injections)
    • ginkgolinter: from 0.21.2 to 0.22.0 (support for wrappers)
    • golines: from 0.14.0 to 0.15.0
    • misspell: from 0.7.0 to 0.8.0
    • revive: from v1.13.0 to v1.14.0 (new rules: epoch-naming, use-slices-sort)
    • unqueryvet: from 1.4.0 to 1.5.3 (new options: check-n1, check-sql-injection, check-tx-leaks, allow, custom-rules)
    • wsl_v5: from 5.3.0 to 5.6.0 (new rule: after-block)
  3. Linters bug fixes
    • modernize: from 0.41.0 to 0.42.0
    • prealloc: from 1.0.1 to 1.0.2
    • protogetter: from 0.3.18 to 0.3.20
  4. Misc.
    • Log information about files when configuration verification
    • Emit an error when no linters enabled
    • Do not collect VCS information when loading code

v2.8.0

Compare Source

Released on 2026-01-07

  1. Linters new features or changes
    • godoclint: from 0.10.2 to 0.11.1 (new rule: require-stdlib-doclink)
    • golines: from 442fd00 to 0.14.0
    • gomoddirectives: from 0.7.1 to 0.8.0
    • gosec: from daccba6 to 2.22.11 (new rule: G116)
    • modernize: from 0.39.0 to 0.40.0 (new analyzers: stringscut, unsafefuncs)
    • prealloc: from 1.0.0 to 1.0.1 (message changes)
    • unqueryvet: from 1.3.0 to 1.4.0 (new options: check-aliased-wildcard, check-string-concat, check-format-strings, check-string-builder, check-subqueries, ignored-functions, sql-builders)
  2. Linters bug fixes
    • gocritic: from 0.14.2 to 0.14.3
    • errorlint: from 1.8.0 to 1.9.0
    • govet: from 0.39.0 to 0.40.0
    • protogetter: from 0.3.17 to 0.3.18
    • revive: add missing enable-default-rules setting
  3. Documentation
    • docs: split installation page

v2.7.2

Compare Source

Released on 2025-12-07

  1. Linter bug fixes

v2.7.1

Compare Source

Released on 2025-12-04

  1. Linter bug fixes
    • modernize: disable stringscut analyzer

v2.7.0

Compare Source

Released on 2025-12-03

  1. Bug fixes
    • fix: clone args used by custom command
  2. Linters new features or changes
    • nosprintfhostport: from 0.2.0 to 0.3.1 (ignore string literals without a colon)
    • unqueryvet: from 1.2.1 to 1.3.0 (handles const and var declarations)
    • revive: from 1.12.0 to 1.13.0 (new option: enable-default-rules, new rules: forbidden-call-in-wg-go, unnecessary-if, inefficient-map-lookup)
    • modernize: from 0.38.0 to 0.39.0 (new analyzers: plusbuild, stringscut)
  3. Linters bug fixes
    • perfsprint: from 0.10.0 to 0.10.1
    • wrapcheck: from 2.11.0 to 2.12.0
    • godoclint: from 0.10.1 to 0.10.2
  4. Misc.
    • Add some flags to the custom command
  5. Documentation
    • docs: split changelog v1 and v2

v2.6.2

Compare Source

Released on 2025-11-14

  1. Bug fixes
    • fmt command with symlinks
    • use file depending on build configuration to invalidate cache
  2. Linters bug fixes
    • testableexamples: from 1.0.0 to 1.0.1
    • testpackage: from 1.1.1 to 1.1.2

v2.6.1

Compare Source

Released on 2025-11-04

  1. Linters bug fixes
    • copyloopvar: from 1.2.1 to 1.2.2
    • gocritic: from 0.14.0 to 0.14.2

v2.6.0

Compare Source

Released on 2025-10-29

  1. New linters
    • Add modernize analyzer suite
  2. Linters new features or changes
    • arangolint: from 0.2.0 to 0.3.1
    • dupword: from 0.1.6 to 0.1.7 (new option comments-only)
    • gocritic: from 0.13.0 to 0.14.0 (new rules/checkers: zeroByteRepeat, dupOption)
    • gofumpt: from 0.9.1 to 0.9.2 ("clothe" naked returns is now controlled by the extra-rules option)
    • perfsprint: from 0.9.1 to 0.10.0 (new options: concat-loop, loop-other-ops)
    • wsl: from 5.2.0 to 5.3.0
  3. Linters bug fixes
    • dupword: from 0.1.6 to 0.1.7
    • durationcheck: from 0.0.10 to 0.0.11
    • exptostd: from 0.4.4 to 0.4.5
    • fatcontext: from 0.8.1 to 0.9.0
    • forbidigo: from 2.1.0 to 2.3.0
    • ginkgolinter: from 0.21.0 to 0.21.2
    • godoclint: from 0.10.0 to 0.10.1
    • gomoddirectives: from 0.7.0 to 0.7.1
    • gosec: from 2.22.8 to 2.22.10
    • makezero: from 2.0.1 to 2.1.0
    • nilerr: from 0.1.1 to 0.1.2
    • paralleltest: from 1.0.14 to 1.0.15
    • protogetter: from 0.3.16 to 0.3.17
    • unparam: from 0df0534 to 5beb8c8
  4. Misc.
    • fix: ignore some files to hash the version for custom build

v2.5.0

Compare Source

Released on 2025-09-21

  1. New linters
  2. Linters new features or changes
    • embeddedstructfieldcheck: from 0.3.0 to 0.4.0 (new option: empty-line)
    • err113: from aea10b5 to 0.1.1 (skip internals of Is methods for error type)
    • ginkgolinter: from 0.20.0 to 0.21.0 (new option: force-tonot)
    • gofumpt: from 0.8.0 to 0.9.1 (new rule is to "clothe" naked returns for the sake of clarity)
    • ineffassign: from 0.1.0 to 0.2.0 (new option: check-escaping-errors)
    • musttag: from 0.13.1 to 0.14.0 (support interface methods)
    • revive: from 1.11.0 to 1.12.0 (new options: identical-ifelseif-branches, identical-ifelseif-conditions, identical-switch-branches, identical-switch-conditions, package-directory-mismatch, unsecure-url-scheme, use-waitgroup-go, useless-fallthrough)
    • thelper: from 0.6.3 to 0.7.1 (skip t.Helper in functions passed to synctest.Test)
    • wsl_v5: from 5.1.1 to 5.2.0 (improvements related to subexpressions)
  3. Linters bug fixes
    • asciicheck: from 0.4.1 to 0.5.0
    • errname: from 1.1.0 to 1.1.1
    • fatcontext: from 0.8.0 to 0.8.1
    • goprintffuncname: from 0.1.0 to 0.1.1
    • godot: from 1.5.1 to 1.5.4
    • gosec: from 2.22.7 to 2.22.8
    • nilerr: from 0.1.1 to a temporary fork
    • nilnil: from 1.1.0 to 1.1.1
    • protogetter: from 0.3.15 to 0.3.16
    • tagliatelle: from 0.7.1 to 0.7.2
    • testifylint: from 1.6.1 to 1.6.4
  4. Misc.
    • fix: "no export data" errors are now handled as a standard typecheck error
  5. Documentation
    • Improve nolint section about syntax

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • "before 9am on monday"
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate CLI.

@github-actions

github-actions Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Dependency Bump Evaluation

Version change: golangci/golangci-lint v2.4.0 to v2.14.0 (minor, spanning 10 minor releases)
Semver bump type: minor

Changes:

  • Linter version bump in CI workflow (.github/workflows/pre-merge.yaml)
  • .golangci.yaml config updates: wsl renamed to wsl_v5, removed deprecated fix: true, gofumpt extra-rules restructured to extra.group-params
  • 9 Go source files modified to satisfy new linter rules:
    • goconst: repeated string literals extracted to package-level constants (mdadm flags, ssacli commands, lsblk flags, storcli2 commands)
    • govet-modernize: two-step slice allocation simplified to single append() calls
    • Minor formatting adjustment in test file

Breaking changes: None affecting this codebase. The linter has config-level changes across these releases (exhaustruct deprecated for exhaustruct_v5, revive var-naming package checks moved to package-naming, gofumpt config restructured), but these are all addressed in the .golangci.yaml updates.

Security concerns: None. golangci-lint is a development-time linter, not a runtime dependency. No production code paths are affected.

Impact on codebase: All Go source changes are purely mechanical and behavior-preserving - string constant extraction and slice preallocation patterns. The runtime semantics of every modified function remain identical.

CI status: All checks passing (golangci-lint, tests, build-e2e, detect-modules)

Recommendation: SAFE TO MERGE

Notes:

  • PR contains commits from g-carre (human) in addition to renovate bot - automated approval is not possible, a human reviewer should confirm the lint fixes are acceptable
  • The large version span (10 minor releases) introduced many new linter rules; all findings were addressed with mechanical fixes that do not change behavior

--- Claude Code

@scality-renovate
scality-renovate Bot force-pushed the renovate/golangci-golangci-lint-2.x branch from 4019128 to 4904ae0 Compare September 4, 2026 04:11
@scality-renovate scality-renovate Bot changed the title chore(deps): update dependency golangci/golangci-lint to v2.13.1 chore(deps): update dependency golangci/golangci-lint to v2.13.2 Sep 4, 2026
@scality-renovate
scality-renovate Bot force-pushed the renovate/golangci-golangci-lint-2.x branch from 4904ae0 to 9189316 Compare October 2, 2026 04:09
@scality-renovate scality-renovate Bot changed the title chore(deps): update dependency golangci/golangci-lint to v2.13.2 chore(deps): update dependency golangci/golangci-lint to v2.14.0 Oct 2, 2026
@g-carre g-carre added the P3 label Oct 9, 2026

@ezekiel-alexrod ezekiel-alexrod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not for this PR, but I think .golangci.yml needs a follow-up:

  • issues.fix: true hides findings. With it, the 2 wsl issues in logicalvolumegetter/ssacli.go:225 and physicaldrivegetter/ssacli.go:299 are not reported and no file is changed, so CI says 0 issues. With --fix=false they come back. It's already the case on main. I'd remove fix: true and let people run --fix locally.
  • wsl is deprecated, golangci-lint suggests wsl_v5. Same for gofumpt extra-rules, replaced by extra.group-params.

scality-renovate Bot and others added 3 commits October 9, 2026 19:24
…2.14.0

- extract repeated CLI arguments (mdadm, ssacli, lsblk, storcli) into constants
- build argument slices in a single append instead of append-after-literal
- Remove issues.fix: golangci-lint fixed findings in place during the run, so
  CI reported 0 issues while they existed on the checked-out code. Run
  golangci-lint run --fix locally instead.
- Replace the deprecated wsl linter by wsl_v5, and gofumpt extra-rules by
  extra.group-params.
@g-carre
g-carre force-pushed the renovate/golangci-golangci-lint-2.x branch from d84129d to b34f7ec Compare October 9, 2026 17:25
@g-carre

g-carre commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Thanks for the review. I rebased the branch on main, resolving the conflict with #101's lsblk --json flag with a new lsblkJSONFlag constant. I also addressed your .golangci.yaml follow-up in this PR, in b34f7ec:

  • issues.fix: true removed. Confirmed: with it, CI said 0 issues, while --fix=false showed the 2 wsl findings you mentioned. Lint now reports findings, and golangci-lint run --fix is for local use.
  • wsl replaced by wsl_v5. Both findings were a // TODO comment right before a closing }. wsl_v5 no longer flags that, so they go away without code changes.
  • gofumpt extra-rules replaced by extra.group-params. There are no deprecation warnings left.

With golangci-lint 2.14.0 locally, run reports 0 issues (no autofix), fmt --diff is clean, and the tests pass.

@g-carre
g-carre merged commit 5bd5006 into main Oct 9, 2026
9 checks passed
@g-carre
g-carre deleted the renovate/golangci-golangci-lint-2.x branch October 9, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants