Skip to content

Improve CLI error reporting - #194

Merged
calvinleng-science merged 7 commits into
mainfrom
calvin/scary-errors
Oct 20, 2026
Merged

calvinleng-science merged 7 commits into
mainfrom
calvin/scary-errors

Conversation

@calvinleng-science

@calvinleng-science calvinleng-science commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • render gRPC failures as concise server-provided messages instead of raw transport exception representations
  • keep usage output limited to argument parsing errors
  • avoid duplicate client and command-layer error messages while preserving the existing public Device fallback behavior
  • return meaningful failure and cancellation exit codes from the CLI boundary

Validation

  • python -m pytest -q synapse/tests/cli synapse/tests/client (124 passed)
  • pre-commit run --files <changed files>

calvinleng-science and others added 6 commits October 20, 2026 13:27
Render expected RPC and semantic failures without raw transport internals or unrelated usage text, while preserving the existing Device client behavior by opting in from CLI callers.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Let the CLI render expected SSH failures without first emitting a root logger diagnostic.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Report missing data and legacy configuration files directly instead of surfacing NoneType errors or unrelated display warnings.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@calvinleng-science
calvinleng-science merged commit aacb0ba into main Oct 20, 2026
2 checks passed
@calvinleng-science
calvinleng-science deleted the calvin/scary-errors branch October 20, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant