Skip to content

Only add discourse link when configured - #722

Merged
stefanv merged 1 commit into
scientific-python:mainfrom
jarrodmillman:fix-comments-link
Sep 26, 2026
Merged

stefanv merged 1 commit into
scientific-python:mainfrom
jarrodmillman:fix-comments-link

Conversation

@jarrodmillman

Copy link
Copy Markdown
Member

See scientific-python/specs#435 which is erroring with

2:31:02 PM:   ✖ FAIL fragment-check public/news/index.html --> #discourse-comments
2:31:02 PM:   | operator: fragment-check
2:31:02 PM:   | expected: id="discourse-comments"
2:31:02 PM:   |       at: public/news/index.html:134:79 <a href="#discourse-comments">...</a>

@jarrodmillman jarrodmillman added the type: Bug fix Something isn't working label Sep 25, 2026
@netlify

netlify Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a088e46
🔍 Latest deploy log https://app.netlify.com/projects/scientific-python-hugo-theme/deploys/6ab6f248e882570008eddf00
😎 Deploy Preview https://deploy-preview-722--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91
Accessibility: 97
Best Practices: 100
SEO: 91
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@jarrodmillman

Copy link
Copy Markdown
Member Author

@agriyakhetarpal I am not sure this is correct. Could you take a look?

@stefanv
stefanv merged commit 5ff7a92 into scientific-python:main Sep 26, 2026
7 checks passed
@stefanv stefanv added this to the 0.23.1 milestone Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: Bug fix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants