Repository navigation
Conversation
seccomp_export_bpf() issues a single write() and only checks for a negative return value, so if the write is short (e.g. a non-blocking pipe with less room than the program, or RLIMIT_FSIZE, or ENOSPC after some data was written) it returns success while only a part of the filter was written. Loop until the whole program is written, retrying on EINTR, and fail if write() returns an error or does not make progress. Add a test case using a non-blocking pipe which is smaller than the filter program. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seccomp_export_bpf()issues a singlewrite()and only checks for a negative return value. If the write is short (a non-blocking pipe with less room than the program,RLIMIT_FSIZE, orENOSPCafter some data was written), it returns success while only a part of the filter was written.This was noticed in crun (containers/crun#2342), which writes the exported filter into a cache, so a truncated filter could be stored and used later.
The fix is to:
EINTR;write()returns an error or makes no progress.A test case (which fails without the fix) is added to
11-basic-basic_errors.