netbios: support a list of names in nbns_resolve - #5217
Open
Skarthik06 wants to merge 2 commits into
Open
Skarthik06 wants to merge 2 commits into
Skarthik06 wants to merge 2 commits into
Conversation
The cache key introduced in secdev#5115 contained the list (or bytearray) as is, which raised TypeError: unhashable type. A list now resolves each name separately and returns a dict, and a bytearray is converted to bytes. AI-Assisted: yes (Claude Sonnet 5.5)
Cover a list with duplicate names, raw and default results of the same name, and names cached before a timeout in a list. AI-Assisted: yes (Claude Sonnet 5.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5202
nbns_resolve()used the unhashableqname(a list or abytearray) in its cache key, which raised aTypeError. A list of names is now resolved one name at a time and returned as a dict{name: result}; abytearrayis converted tobytes. Single-name behaviour is unchanged.Reproduction (before the fix):
This PR was written with the help of AI (Claude Sonnet 5.5).