Repository navigation
docs(netlify-api): document baseUrl on the Effect layer - #269
Merged
Merged
Conversation
The README still said makeApiLayer ignores baseUrl, but the fetcher has honoured it since base-url-config, so readers could not tell that a proxy or test server can be set. State that baseUrl is the host only, with /api/v1 added, and that a call can pass it in config. Closes #267
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #267
Corrects the netlify-api README: makeApiLayer and a call's config take a baseUrl host, with /api/v1 added. Patch changeset for netlify-api.