Skip to content

fix: use the ShellUI logo as the NuGet package icon - #43

Merged
Shewart merged 2 commits into
mainfrom
fix/package-icon
Oct 9, 2026
Merged

Shewart merged 2 commits into
mainfrom
fix/package-icon

Conversation

@Shewart

@Shewart Shewart commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Neither package set PackageIcon, so nuget.org showed the default icon for ShellUI.CLI and ShellUI.Components. src/ShellUI.Components/icon.svg was an unused placeholder.

  • assets/icon.png is the ShellUI >| dot mark on a dark rounded tile, 256 px, which reads on nuget.org's light and dark themes
  • Directory.Build.props sets it as PackageIcon and packs it once for both packages
  • assets/icon.svg is kept as the source
  • src/ShellUI.Components/icon.svg is removed

Both packages now ship icon.png with <icon>icon.png</icon> in the nuspec.

Shewatipa Tseisi added 2 commits October 6, 2026 10:23
Neither package set PackageIcon, so nuget.org showed the default icon, and src/ShellUI.Components/icon.svg was an unused placeholder. assets/icon.png (the dot mark on a dark tile) is now the icon of ShellUI.CLI and ShellUI.Components, with assets/icon.svg as its source.
nuget.org renders Markdown only and accepts images from raw.githubusercontent.com. assets/readme-logo.svg is the brand tile at 64 px (ink on light, paper on dark), drawn with md-files brand/generate.py; it shows once this branch is on main.
Copilot AI balanced review requested due to automatic review settings October 9, 2026 18:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Shewart
Shewart merged commit 99d30a5 into main Oct 9, 2026
1 check passed
@Shewart
Shewart deleted the fix/package-icon branch October 9, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants