Repository navigation
fix: stop shellui-theme.css requesting tailwindcss when linked directly - #44
Merged
Merged
Conversation
The theme started with @import "tailwindcss";, so a page that links it asked the browser for a tailwindcss URL and logged a 404 on every load. The CSS build script now writes the import into its generated input, so the theme file holds only the theme and shellui-all.css is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/ShellUI.Components/wwwroot/shellui-theme.cssstarted with@import "tailwindcss";. A page that links the theme directly (<link href="_content/ShellUI.Components/shellui-theme.css">, as the docs site does) made the browser requesttailwindcssas a URL and log a 404 on every load.shellui-theme.cssnow holds only the themescripts/rebuild-precompiled-css.shwrites@import "tailwindcss";at the top of its generated Tailwind input; it is the only thing that builds from the theme fileChecked:
shellui-all.cssis byte-for-byte identical before and aftershellui-theme.cssfrom the package: the stylesheet loads, there is notailwindcssrequest, the console is clean, and--backgroundapplies