Repository navigation
Align the repository with awesome-humans/dotnet - #193
Merged
Merged
Conversation
Adds .gitattributes so checkouts stay LF. No content changes.
- Opt in to the MTP runner in global.json, and roll the SDK forward with latestFeature. - Replace xunit v2, Microsoft.NET.Test.Sdk, coverlet, and xunit.runner.visualstudio with xunit.v3 and Microsoft.Testing.Extensions.CodeCoverage. - Align Directory.Build.props and Directory.Packages.props with the awesome-humans/dotnet templates: artifacts output, latest-recommended analysis, Meziantou.Analyzer, nullable warnings as errors, documentation file, deterministic builds, and transitive pinning. - Pin FSharp.Core to 10.1.402, the version the .NET 10.0.400 SDK ships. - Pin GitHub Actions to commit SHAs, take the SDK from global.json, set least-privilege permissions, and upload TRX and coverage results. - Add a /build/ solution folder for the root build files.
Keeps this repository's var style, PascalCase static readonly fields, and ReSharper settings. Silences rules that clash with LeetCode's given signatures and the partial Problem class, each with a reason. Fixes the rest in code, mostly with dotnet format.
Drops CLAUDE.md, which only imported AGENTS.md, and updates the single-test command for MTP.
Spectre.Console falls back to Console.SetCursorPosition without a terminal, and moving up from the first row threw ArgumentOutOfRangeException in list and benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the findings from a verify-project review against awesome-humans/dotnet at
15e661e. Test names stay as they are, and tests stay beside their solutions..gitattributes. This commit has no content changes, so review the others on their own.global.json. Replaces coverlet withMicrosoft.Testing.Extensions.CodeCoverage. The console app setsIsTestProjecttofalse, sodotnet testdoesn't try to run it.Directory.Build.propsandDirectory.Packages.propsfollow the templates: artifacts output,latest-recommendedanalysis, Meziantou.Analyzer, nullable warnings as errors, deterministic builds, and transitive pinning. FSharp.Core goes from 8.0.400 to 10.1.402, the version the SDK ships.global.json, setscontents: readby default andcontents: writeonly for the benchmark job, and uploads TRX and Cobertura results..editorconfig, but keeps the repository'svarstyle, PascalCasestatic readonlyfields, and ReSharper settings. Rules that clash with LeetCode's given signatures or the partialProblemclass are off, each with a reason: MA0048, MA0016, CA1002, CA1051, and MA0026. Spectre1010 is also off, because Spectre.Console.Analyzer 1.0.0 crashes on it.dotnet format. The hand fixes are culture-aware formatting, aGeneratedRegexpartial property with a match timeout, and a single dictionary lookup inTopKFrequentthroughCollectionsMarshal.GetValueRefOrAddDefault.Console.SetCursorPosition, andlistandbenchmarkthrewArgumentOutOfRangeExceptiononmain.AGENTS.md, updates the single-test command for MTP, and dropsCLAUDE.md.Test plan
dotnet build -c Releasefrom a cleanartifacts/passes with no warnings.dotnet format --verify-no-changespasses.dotnet test -c Releaseruns 80 tests, and all pass. TRX and coverage files land inartifacts/test-results.dotnet run --project LeetCode -c Release -- benchmark FizzBuzz --csharpcompletes in a terminal.listandbenchmark FizzBuzz --csharpsucceed with output redirected to a file, andliststill moves the cursor in a terminal.