Repository navigation
Restore the original console writer after benchmarks run - #196
Merged
Merged
Conversation
Console.SetOut(Console.Out) ran after Console.Out was already TextWriter.Null, so it restored nothing. Save the writer first, and restore it in a finally block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BenchmarkRunner.BuildSummariesmutes the console withConsole.SetOut(TextWriter.Null)while the spinner runs. It then calledConsole.SetOut(Console.Out), butConsole.Outwas already the null writer at that point, so plainConsoleoutput stayed muted afterwards.The method now saves the original writer and restores it in a
finallyblock, so a benchmark that throws doesn't leave the console muted either. Spectre.Console output wasn't affected, because it keeps its own writer.Test plan
dotnet build -c Releaseanddotnet format --verify-no-changespass.benchmark FizzBuzz --csharpprints its summary table, and BenchmarkDotNet's log stays hidden while the spinner runs.