Repository navigation
Move discussions panel into a drawer - #800
Merged
Merged
Conversation
…when no width is given
jeehoh
changed the title
jeehoh
marked this pull request as ready for review
November 4, 2026 23:16
Collaborator
|
Before I get into an in-depth review, I notice that in Balsamiq we have a specific note that desktop will utilize a "slide adjacent" layout and not a "slide over" layout. I guess either way could be fine, but this is a discrepancy. It may be valuable to do a more fleshed out design in Balsamiq that thinks through the implications of whichever path we choose. If our implementation intentionally diverges from the design, I think it'd be helpful to align the two. (I do remember, however, that the prototype uses a "slide over" layout for both platforms.) 
|
Collaborator
|
So after talking, we're going to update Balsamiq and keep the drawer design (until further notice). |
josephmyers
requested changes
Nov 5, 2026
Collaborator
|
Oh, by the way, excellent work so far. Loving all the code removed. |
…m unsent comments before closing
josephmyers
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
This PR moves the discussions panel into a drawer that overlays the workflow step. It also replaces the JS width and height calculations (based on magic numbers, usePaneWidth (which became obsolete due to moving away from panel approach), getScrollbarWidth) with CSS and flexbox.
Screenshots:
[Before]
[After]
