Skip to content

Respect the configured namespace for manual pageviews #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adriaandotcom merged 3 commits into from
Oct 15, 2026
Merged

Respect the configured namespace for manual pageviews #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71df33b
Respect the configured namespace for manual pageviews
Oct 15, 2026
cf05276
Retain the free legacy manual pageview alias
Oct 15, 2026
492f671
Merge v12 into fix/v12-namespaced-pageviews
Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 93 additions & 6 deletions dist/latest/cloudflare.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Simple Analytics - Privacy-first analytics (docs.simpleanalytics.com/script; 2026-10-15; 6182; v12) */
/* Simple Analytics - Privacy-first analytics (docs.simpleanalytics.com/script; 2026-10-15; f3cb; v12) */
/* eslint-env browser */

(function (
Expand Down Expand Up @@ -298,7 +298,7 @@
//

// Send data via image
var sendData = function (data, callback, onlyThisData) {
var sendData = function (data, callback, onlyThisData, keepalive) {
data = onlyThisData ? data : assign(payload, page, data);

if (nav.brave && !onlyThisData) data.brave = trueVar;
Expand All @@ -310,7 +310,7 @@
image.onerror = callback;
image.onload = callback;
}
image.src =
var imageUrl =
fullApiUrl +
"/simple.gif?" +
Object.keys(data)
Expand All @@ -327,6 +327,23 @@
.join("&") +
"&time=" +
Date.now();

// Inline events must survive navigation without taking over links or forms.
if (keepalive && window.fetch) {
try {
window
.fetch(imageUrl, {
keepalive: trueVar,
mode: "no-cors",
credentials: "omit",
})
.catch(function () {
image.src = imageUrl;
});
return;
} catch (error) {}
}
image.src = imageUrl;
};

// Customers can overwrite their hostname, here we check for that
Expand Down Expand Up @@ -895,9 +912,12 @@

if (autoCollect) pageview();

window.sa_pageview = function (path, metadata, callback) {
var manualPageview = function (path, metadata, callback) {
pageview(0, path, metadata, callback);
};
window[namespace + "_" + pageviewText] = manualPageview;
var defaultPageview = defaultNamespace + "_" + pageviewText;
if (!window[defaultPageview]) window[defaultPageview] = manualPageview;


/////////////////////
Expand All @@ -906,7 +926,7 @@

var validTypes = ["string", "number"];

var sendEvent = function (event, metadata, callbackRaw) {
var sendEvent = function (event, metadata, callbackRaw, keepalive) {
if (!callbackRaw && isFunction(metadata)) callbackRaw = metadata;

var eventIsFunction = isFunction(event);
Expand Down Expand Up @@ -954,7 +974,9 @@

metadata: stringify(metadata),
}),
callback
callback,
undefinedVar,
keepalive
);
}
};
Expand Down Expand Up @@ -983,6 +1005,71 @@
: sendEvent(queue[event]);
}
}

var inlineEvent = function (event) {
var element = event.target;
while (
element &&
element !== doc &&
(!element.getAttribute || attr(element, "simple-event") === null)
)
element = element.parentNode;

if (!element || element === doc) return;
var isForm = element.tagName === "FORM";
var name = attr(element, "simple-event");
if (!name || isForm !== (event.type === "submit")) return;

var metadata = { tag: element.tagName.toLowerCase() };
var attributes = element.attributes;
for (var i = 0; i < attributes.length; i++) {
var attribute = attributes[i];
if (attribute.name.indexOf("data-simple-event-") === 0)
metadata[attribute.name.slice(18).replace(/-/g, "_")] =
attribute.value;
}
if (isForm) {
var button = event.submitter;
metadata.button_text = button
? (button.textContent || button.value || "")
.replace(/\s+/g, " ")
.trim()
.slice(0, 200)
: "";
}
sendEvent(name, metadata, undefinedVar, trueVar);
};

doc.addEventListener("click", inlineEvent, falseVar);
doc.addEventListener("submit", inlineEvent, falseVar);

// 404 confirmation adds a request, so existing installs must opt in.
if (
overwriteOptions.detect404 === trueVar ||
attr(scriptElement, "detect-404") == trueText
) {
var detect404 = function () {
if (
!/\b404\b/.test(doc.title + " " + (doc.body && doc.body.textContent))
)
return;
try {
var request = new window.XMLHttpRequest();
request.open("HEAD", loc.href, trueVar);
request.onload = function () {
if (request.status === 404)
sendEvent("page_404", {
url: loc.protocol + "//" + definedHostname + loc.pathname,
status: 404,
});
};
request.send();
} catch (error) {}
};
if (doc.readyState === "loading")
doc.addEventListener("DOMContentLoaded", detect404, falseVar);
else detect404();
}
} catch (e) {
sendError(e);
}
Expand Down
4 changes: 2 additions & 2 deletions dist/latest/custom/app.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/latest/custom/app.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/latest/custom/e.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/latest/custom/e.js.map
View file
Open in desktop

Large diffs are not rendered by default.

99 changes: 93 additions & 6 deletions dist/latest/custom/latest.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Simple Analytics - Privacy-first analytics (docs.simpleanalytics.com/script; 2026-10-15; cd25; v12) */
/* Simple Analytics - Privacy-first analytics (docs.simpleanalytics.com/script; 2026-10-15; 079c; v12) */
/* eslint-env browser */

(function (
Expand Down Expand Up @@ -296,7 +296,7 @@
//

// Send data via image
var sendData = function (data, callback, onlyThisData) {
var sendData = function (data, callback, onlyThisData, keepalive) {
data = onlyThisData ? data : assign(payload, page, data);

if (nav.brave && !onlyThisData) data.brave = trueVar;
Expand All @@ -309,7 +309,7 @@
image.onerror = callback;
image.onload = callback;
}
image.src =
var imageUrl =
fullApiUrl +
"/simple.gif?" +
Object.keys(data)
Expand All @@ -326,6 +326,23 @@
.join("&") +
"&time=" +
Date.now();

// Inline events must survive navigation without taking over links or forms.
if (keepalive && window.fetch) {
try {
window
.fetch(imageUrl, {
keepalive: trueVar,
mode: "no-cors",
credentials: "omit",
})
.catch(function () {
image.src = imageUrl;
});
return;
} catch (error) {}
}
image.src = imageUrl;
};

// Customers can overwrite their hostname, here we check for that
Expand Down Expand Up @@ -895,9 +912,12 @@

if (autoCollect) pageview();

window.sa_pageview = function (path, metadata, callback) {
var manualPageview = function (path, metadata, callback) {
pageview(0, path, metadata, callback);
};
window[namespace + "_" + pageviewText] = manualPageview;
var defaultPageview = defaultNamespace + "_" + pageviewText;
if (!window[defaultPageview]) window[defaultPageview] = manualPageview;


/////////////////////
Expand All @@ -906,7 +926,7 @@

var validTypes = ["string", "number"];

var sendEvent = function (event, metadata, callbackRaw) {
var sendEvent = function (event, metadata, callbackRaw, keepalive) {
if (!callbackRaw && isFunction(metadata)) callbackRaw = metadata;

var eventIsFunction = isFunction(event);
Expand Down Expand Up @@ -954,7 +974,9 @@

metadata: stringify(metadata),
}),
callback
callback,
undefinedVar,
keepalive
);
}
};
Expand Down Expand Up @@ -983,6 +1005,71 @@
: sendEvent(queue[event]);
}
}

var inlineEvent = function (event) {
var element = event.target;
while (
element &&
element !== doc &&
(!element.getAttribute || attr(element, "simple-event") === null)
)
element = element.parentNode;

if (!element || element === doc) return;
var isForm = element.tagName === "FORM";
var name = attr(element, "simple-event");
if (!name || isForm !== (event.type === "submit")) return;

var metadata = { tag: element.tagName.toLowerCase() };
var attributes = element.attributes;
for (var i = 0; i < attributes.length; i++) {
var attribute = attributes[i];
if (attribute.name.indexOf("data-simple-event-") === 0)
metadata[attribute.name.slice(18).replace(/-/g, "_")] =
attribute.value;
}
if (isForm) {
var button = event.submitter;
metadata.button_text = button
? (button.textContent || button.value || "")
.replace(/\s+/g, " ")
.trim()
.slice(0, 200)
: "";
}
sendEvent(name, metadata, undefinedVar, trueVar);
};

doc.addEventListener("click", inlineEvent, falseVar);
doc.addEventListener("submit", inlineEvent, falseVar);

// 404 confirmation adds a request, so existing installs must opt in.
if (
overwriteOptions.detect404 === trueVar ||
attr(scriptElement, "detect-404") == trueText
) {
var detect404 = function () {
if (
!/\b404\b/.test(doc.title + " " + (doc.body && doc.body.textContent))
)
return;
try {
var request = new window.XMLHttpRequest();
request.open("HEAD", loc.href, trueVar);
request.onload = function () {
if (request.status === 404)
sendEvent("page_404", {
url: loc.protocol + "//" + definedHostname + loc.pathname,
status: 404,
});
};
request.send();
} catch (error) {}
};
if (doc.readyState === "loading")
doc.addEventListener("DOMContentLoaded", detect404, falseVar);
else detect404();
}
} catch (e) {
sendError(e);
}
Expand Down
4 changes: 2 additions & 2 deletions dist/latest/custom/latest.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/latest/custom/latest.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/latest/custom/light.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/latest/custom/light.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading