Repository navigation
Make the existing v12 unit tests runnable from a clean checkout - #113
simple-analytics-ai[bot] wants to merge 1 commit into
Conversation
Review of the requested compatibility PRs found the unit suite lacked jsdom and a test:unit command. Keep this support repair separate, run it in CI, and leave shipped script bytes unchanged. Refs #107
Claude review checkpointReviewed commit |
|
SDLC label: |
|
Superseded by current v12: package.json already declares jsdom 26.1.0 and test:unit, the frozen lockfile includes that dependency, and the workflow runs the build plus unit suite even when BrowserStack is skipped. Current v12 passes a clean frozen install and 39 unit tests after building. Merging this older branch would replace the current test command and conflict with already-landed workflow and dependency updates, so it is no longer needed for #107. |
Requested: resolve conflicts on scripts PR #113 and merge the latest v12 branch into it. Keep the unit-test command self-building and retain v12's Mocha --exit option, current jsdom/Handlebars dependencies, tracker changes, and CI setup. Validation: frozen installation, build plus 41 unit tests, 11 matrix tests, 12 deployment tests, TypeScript, changed-file formatting, and diff checks passed.
Base: #40 (
v12). Merge this support PR intov12.Status: Closed as superseded by the parallel #107 cleanup. For this request, the branch was updated afterward with
v12@3395422in merge commit 40c69f3. It remains closed; no new CI run was triggered.Summary
Fixes #107
Make
pnpm run test:unitbuild the tracker before running Mocha, while retainingv12's--exitoption. CI calls that single command.Requested update: resolve PR #113's conflicts and merge the current
v12branch into it. The jsdom dependency and CI unit-test step have since landed through #106; keep those changes and the newer Handlebars dependency. Only two tooling lines differ fromv12; tracker source and committed distribution bytes match it exactly.Security implications
Testing
v12; its standalone unit command depended on an existing build.test:unitrebuilt successfully and all 41 tests passed.git diff --checkpassed.mainwas refreshed through the broker and is included in the mergedv12history.Merge Danger
Door: two-way. Blast Radius: tooling.
Checklist