Repository navigation
Conversation
…ilure trivy-branch never ran once grype-branch failed the job, since it had no if: condition of its own -- the step was skipped rather than run, so the pending-release diff treated an empty (not scanned) branch result as "no Trivy findings on branch", misclassifying any still-unfixed Trivy CVE in the release image as merely pending release. Mark the two gating scans continue-on-error and fail the job explicitly afterwards instead, so a real finding no longer skips the informational scans, the diff, or the SBOM upload.
Hamdy-khader
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trivy-branch never ran once grype-branch failed the job, since it had no if: condition of its own -- the step was skipped rather than run, so the pending-release diff treated an empty (not scanned) branch result as "no Trivy findings on branch", misclassifying any still-unfixed Trivy CVE in the release image as merely pending release.
Mark the two gating scans continue-on-error and fail the job explicitly afterwards instead, so a real finding no longer skips the informational scans, the diff, or the SBOM upload.