feat(mcp): support OAuth on workflow MCP servers - #8206
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/mcp/serve/{serverId}) now accept Sim OAuth access tokens, so clients that only speak MCP OAuth (claude.ai / ChatGPT connectors, Claude Code, Cursor) can connect to private servers without pasting an API keyinvalid_tokenWWW-Authenticatechallenge pointing at new RFC 9728 metadata at/.well-known/oauth-protected-resource/api/mcp/serve/{serverId}, so clients can discover the auth server and start the flow/api/mcp/serve/{id}as a resource in the existingapiscope family (no new scopes); listing tools needsapi:read,tools/callneedsapi:writeand returns aninsufficient_scopestep-up otherwiseType of Change
Testing
invalid_token, read-only token →insufficient_scope, removed member → 403, personal-key policy, API key wins over bearer), resource parsing, and the metadata routetools/list/tools/callwith bound tokens, step-up, rejection of Sim MCP-bound and unbound tokens, and/oauth2/authorizeaccepting the server URL asresourcebun run lint,check:audits(47 audits),check:api-validation,type-checkpassChecklist