Skip to content

[ENHANCEMENT] Remove misleading indexing leftovers and comments #39

Open

Description

@simurg79

Type

Enhancement — maintenance follow-up

Problem / Value

Small leftovers from the parser-isolation change make indexing code harder to maintain. One timeout setting has no caller, an error value is permanently empty, and two comments are misplaced or obsolete.

Context

Deferred findings 🟢7, 🟢8, and 🟢11 from PR #34: #34, which addresses #23. Source reviewed: 8c38f1c.

  • Finding 7: remove or justify the unused indexing-stop timeout constant. Simplify the always-empty batch error value. Qualification: that value is passed to the progress event, so it is redundant state rather than a wholly unreferenced variable.
  • Finding 8: the file-processing documentation is attached to the fatal-error reporting helper instead of the file-processing operation.
  • Finding 11: remove the commented-out line-count calculation and its obsolete lint explanation.

Acceptance criteria

  • Resolve all three findings without changing indexing behavior or event semantics.
  • Place necessary documentation on the operation it describes; remove comments that add no value.
  • Keep unrelated status/translation decisions in the separate stop-status follow-up.
  • Run relevant existing checks and tests when implementing this cleanup.

Constraints/Preferences

Keep this a small maintenance change; do not add configuration or abstractions to justify dead code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions