Skip to content

[vscode-lm] Remove the redundant model placeholder guard #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simurg79 merged 1 commit into from
Oct 29, 2026
Merged

[vscode-lm] Remove the redundant model placeholder guard #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions packages/types/src/__tests__/vscode-llm.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,9 @@ const SCOPED_ROWS = {
"gemini-3.6-flash": { contextWindow: 935793, maxInputTokens: 935785, supportsImages: true },
} as const

const REFRESHED_FAMILIES = Object.keys(SCOPED_ROWS) as Array<keyof typeof SCOPED_ROWS>

describe("vscodeLlmModels", () => {
it("exposes the opus-4.8 row with its measured maxInputTokens and contextWindow", () => {
// claude-opus-4.8 intentionally DIVERGES: maxInputTokens (197897) is the enforced ceiling the
// UI reads, contextWindow (679560) the larger advertised window. Assert the on-disk literals
// rather than forcing equality.
// The two values differ for this row, so pin the exact stored values rather than forcing equality.
expect(vscodeLlmModels).toHaveProperty("claude-opus-4.8")
expect(vscodeLlmModels["claude-opus-4.8"].contextWindow).toBe(679560)
expect(vscodeLlmModels["claude-opus-4.8"].maxInputTokens).toBe(197897)
Expand Down Expand Up @@ -53,16 +49,6 @@ describe("vscodeLlmModels", () => {
expect(vscodeLlmModels["gemini-3.6-flash"].contextWindow).toBe(935793)
})

it("leaves no 2026-09-10 scoped family pinned to the 197897 placeholder", () => {
// Untouched rows (e.g. claude-opus-4.7) legitimately still measure 197897, so this guard is
// limited to the families this refresh touched.
for (const family of REFRESHED_FAMILIES) {
expect(vscodeLlmModels[family].maxInputTokens, `${family} must not be the 197897 placeholder`).not.toBe(
197897,
)
}
})

it("pins every 2026-09-10 row's windows and capability flags", () => {
for (const [family, expected] of Object.entries(SCOPED_ROWS)) {
const model = vscodeLlmModels[family as keyof typeof vscodeLlmModels]
Expand Down
Loading