Repository navigation
Update skale.py-core to 8.0dev3 and helper-scripts to f3324bd - #1003
Merged
Merged
Conversation
badrogger
approved these changes
Nov 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves node-cli to skale.py-core 8.0dev3 and the helper-scripts submodule to helper-scripts develop. No code changes.
skale_corepackage is identical in the two wheels and keeps the same requirements (pydantic-settings>=2.14.2, tomli-w>=1.2.0), soskale_core.settingsandskale_core.types, which node-cli imports, are unchanged. The resolved runtime set differs from develop only in skale-py-core.run_anvilmoves from foundry v1.4.0 → v1.9.0, redis/run.sh from redis 8.0.1 → 8.10.3,deploy_managerrunsyarn hardhatand stops early when the Manager image writes no contracts file, load_geth.py and the GANACHE_VERSION export are gone, and requirements.txt moves boto3 1.13.7 → 1.44.1, drops pyyaml 5.4 and adds jinja2 3.1.6. This repo only usescalculate_version.sh(publish.yml), which is byte-identical between the two commits, and helper-scripts is not part of the builder image (.dockerignore).node-cli pins no MANAGER_TAG and no sgxwallet simulator image, so those parts of the round do not apply here. Independent of #1000, which edits other lines of pyproject.toml; the two merge without conflict.
Tested locally
The test.yml and audit.yml jobs ran step by step in an amd64 Ubuntu 24.04 Docker-in-Docker runner on Apple Silicon, not on GitHub, with uv 0.13.8 instead of the pinned 0.13.6. On CPython 3.14.10,
uv sync --all-extrasinstalls skale.py-core 8.0dev3, and ruff check passes. The node-cli-builder image builds, PyInstaller 6.22.3 builds the skale and fair binaries, and both print their help with exit 0. The nftables tests give 45 passed. The first run of the tests gave 289 passed and 2 failed, both because of the runner image: it had no tzdata, sotests/cli/schains_test.py::test_ls, which sets TZ=Europe/London, printed times in UTC, and nobtrfsbinary, whichtests/core/core_schains_test.py::test_cleanup_passive_datadirruns throughis_btrfs_subvolume. With tzdata and btrfs-progs installed in the runner, the tests give 291 passed, the same counts as the last develop run on GitHub (44156254848, at ba4051e). pip-audit 2.10.1 (OSV) on the audit.yml export finds no known vulnerabilities.Not run: the GitHub jobs themselves and publish.yml, which runs on merge and is the only workflow that uses the helper-scripts submodule.
Part of skalenetwork/skale-node#891