Skip to content

chore: clarify return docs and preserve admission keys #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harlan-github-agent wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

chore: clarify return docs and preserve admission keys #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions checks/_helpers/policy.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { fail, pass, warn } from '@harlan-zw/nuxt-checkin/external'

/** @returns {import('@harlan-zw/nuxt-checkin/external').CheckResult} */
/** @returns {import('@harlan-zw/nuxt-checkin/external').CheckResult} Workflow health verdict with evidence coverage. */
export function evaluateCI(data) {
const incomplete = !data.workflows.length || data.workflows.some(workflow => workflow.state._tag === 'missing'
|| (workflow.state._tag === 'pending' && workflow.state.previousConclusion === null))
Expand All @@ -14,7 +14,7 @@ export function evaluateCI(data) {
return pass(data)
}

/** @returns {import('@harlan-zw/nuxt-checkin/external').CheckResult} */
/** @returns {import('@harlan-zw/nuxt-checkin/external').CheckResult} Database health verdict with evidence coverage. */
export function evaluateD1(data, now, since) {
const missingReason = data.missingExpectedTables.length
? 'Expected database tables are missing.'
Expand Down
4 changes: 2 additions & 2 deletions layers/marketing/app/utils/page-admissions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export const FREEZE_AUDIT_PATHS: readonly string[] = [
'/skills/demos',
]

export const PAGE_ADMISSIONS: Readonly<Record<string, PageAdmission>> = {
export const PAGE_ADMISSIONS = {
'/learn/research/skill-md-size-study': {
targetQuery: 'SKILL.md size and description length',
admissionBar: 'Owner-approved original research, 2026-10-09. One frozen registry study with source hashes, downloadable measurements, methods, weighting comparisons, and an authoring-guide action. Specific size queries have no DataForSEO estimate; the broader skill md seed has 720 US searches a month, KD 28. Research authority and citations are explicit goals, independent of search volume. Review indexing, relevant impressions, citations, and authoring-guide clicks at the 2026-11-11 gate. Retain useful cited research; consolidate into the authoring guide if it has no distinct use.',
Expand Down Expand Up @@ -96,7 +96,7 @@ export const PAGE_ADMISSIONS: Readonly<Record<string, PageAdmission>> = {
targetQuery: 'context7 vs skills',
admissionBar: 'The human-written template that experiment C rolls out to concept pages. No measured volume; kept as the control.',
},
}
} satisfies Readonly<Record<string, PageAdmission>>

/** True when the audit covers the path. Agent and comparison pages always count. */
function isAudited(path: string): boolean {
Expand Down
Loading