Repository navigation
Fix flaky proposal confirm spec and happening now ordering - #433
Merged
Merged
Conversation
Wait for the redirect to the registration page before checking the flash. Reading the page mid-navigation intermittently failed in CI with Chrome's "Node with given id does not belong to the document". Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
HappeningNowQuery ordered by start time, then room order. Sessions in the same slot whose rooms have no order came back in arbitrary order, so pagination could repeat or skip sessions across pages (seen as a flaky splashpage pagination spec). Add id as the final tiebreaker, matching the old creation-order behavior. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
cycomachead
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two intermittent CI failures.
1.
proposals_spec.rb"confirms a proposal" failed on #429 and #432 (same commits passed on rerun) with Chrome's "Node with given id does not belong to the document". Clicking Confirm sends a PATCH and redirects, and the spec read the page mid-navigation. It now waits for the registration page path first, then checks the flash.2.
splashpage_spec.rb"only shows 3 events happening now because of pagination" is a real ordering bug from #426.HappeningNowQuerysorted by start time, then room order. Sessions in the same slot whose rooms have no order came back in arbitrary order. Across paginated pages that can repeat or skip sessions. Addedidas the final tiebreaker, which matches the old creation order. New query spec covers it.🤖 Generated with Claude Code