Repository navigation
Bundle tzinfo-data on all platforms (prep for heroku-24) - #434
Merged
Merged
Conversation
Use bundled time zone data instead of the OS's. heroku-24 (Ubuntu 24.04) moves legacy aliases into tzdata-legacy, which it doesn't install. Rails maps "Midway Island" to Pacific/Midway and "Greenland" to America/Godthab, both legacy aliases, and production users use them. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for moving Heroku from the heroku-22 to the heroku-24 stack.
heroku-24 is Ubuntu 24.04, which moves legacy time zone aliases into the
tzdata-legacypackage; heroku-24 doesn't install it. Rails maps two zone names used in production to such aliases:Pacific/MidwayAmerica/GodthabWith OS zone data those lookups would fail on heroku-24. Heroku's docs recommend
tzinfo-datafor Ruby apps. It was already in the Gemfile, but only for Windows/JRuby. With it everywhere,TZInfo::DataSource.getisRubyDataSourceand both zones resolve locally. Its data loads per zone, on demand.🤖 Generated with Claude Code