Repository navigation
Use Time.zone.today instead of Date.today - #436
Open
cycomachead wants to merge 1 commit into
Open
cycomachead wants to merge 1 commit into
cycomachead wants to merge 1 commit into
Conversation
Date.today uses the machine's time zone rather than the app's config.time_zone, so date checks can be off by a day around midnight when the two differ (and specs can flake on non-UTC dev machines). Replace every Date.today with Time.zone.today and enable the Rails/Date cop so new ones are flagged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #393 with a fresh change on current
main.Date.todayuses the server's time zone, not the app'sconfig.time_zone. When the two differ, "is the conference over?"-style checks can be off by a day around midnight, and specs can fail on non-UTC dev machines.Date.todaywithTime.zone.todayinapp/,lib/, andspec/(105 call sites)Rails/Datein.rubocop.ymlso newDate.todaycalls get flaggedUnlike #393, this leaves the CI screenshot upload step alone.
Testing:
spec/models, the admin cfps/conferences/registration_periods controller specs, and the registration feature specs pass (865 examples, 0 failures). RuboCop reports no new offenses on the changed files.🤖 Generated with Claude Code