Repository navigation
fix(ios): HTML entities encoding/decoding improvements - #849
Merged
Merged
Conversation
szydlovsky
changed the title
szydlovsky
marked this pull request as ready for review
November 2, 2026 16:42
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Attribute references are decoded inconsistently: canonical HTML leaves some references encoded, while Gumbo-processed HTML decodes them twice, altering URLs and other attribute values.
2 open issues
What changed in this PR
Improves iOS HTML entity handling to address #818 and preserve text and attribute values when importing and saving HTML.
Changes:
- Expands named-entity decoding and escapes text in a single pass.
- Adds dedicated attribute encoding and decoding for links, images, mentions, and custom styles.
- Adds a Maestro flow checking named-entity rendering.
| File | Description |
|---|---|
ios/htmlParser/HtmlParser.mm |
Applies attribute helpers during parsing and serialization. |
ios/extensions/StringExtension.mm |
Expands entity handling and implements attribute helpers. |
ios/extensions/StringExtension.h |
Declares the new attribute helpers. |
.maestro/enrichedText/flows/named_html_entities.yaml |
Tests decoded named entities in rendered text. |
Review effort: Balanced
szydlovsky
force-pushed
the
@exploif/ios-named-entities
branch
from
November 2, 2026 19:19
f75474f to
7342c6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #818 by improving the way we escape HTML entities for the whole string.
Also improves our entities encoding/decoding within html attributes - like link and image
URIs, mention custom attributes and custom style data by creating dedicated encoding/decoding methods for them.Test Plan
Screenshots / Videos
Compatibility
Checklist