Repository navigation
Conversation
…ve-enriched-html into @relextm19/scroll-position
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
There was a problem hiding this comment.
🟡 Changes recommended
The new fullscreen row invalidates existing screenshot baselines, and scroll events have cross-platform throttling, unit, and precision errors.
6 open issues
Regenerate fullscreen screenshot baselines after layout changes · New Use inclusive scroll throttle interval comparisons · New Convert native scroll pixels to density-independent coordinates · New Preserve fractional scroll coordinates in native event payloads · New Treat zero scroll throttle as no throttling on web · New Emit the latest scroll offset with trailing throttle delivery · New
Review effort: Balanced
e7a6c07 to
2e5d181
Compare
…ve-enriched-html into @relextm19/scroll-position
…ve-enriched-html into @relextm19/scroll-position
exploIF
left a comment
There was a problem hiding this comment.
I think we should use similar approach to what we are doing for onChangeHtml. If handler is not set up we should avoid any calculations. See how isOnChangeTextSet is implemented
25a8a54 to
17fe873
Compare
szydlovsky
left a comment
There was a problem hiding this comment.
Did a checkup over the layoutSubviews change that bugged me and it looks legit!
|
Code-wise looks good, asked @szydlovsky to do a final testing check 🙌 |
|
@relextm19 actually, I'm seeing some strange Android value jumps from the Screen.Recording.2026-11-12.at.18.28.38.movHaving said that, I think it might be rather an issue of our jumps on layout when adding new lines, rather than the actual offset calculation. The issue is probably unrelated to this PR but I'll do some digging and check what happens on the current |


Summary
Closes #169
Add onScroll event to
EnrichedTextInputtriggered when the content is scrolled. Payload is the same as in the React Native implementationTest Plan
Check the metro logs when running the mobile example or browser logs when running the web test. You can also write your own handler for onScroll and test it yourself
Screenshots / Videos
Compatibility
Checklist