Skip to content

@relextm19/add mention border radius - #856

Merged
szydlovsky merged 19 commits into
mainfrom
@relextm19/add-mention-border-radius
Nov 12, 2026
Merged

szydlovsky merged 19 commits into
mainfrom
@relextm19/add-mention-border-radius

Conversation

@relextm19

Copy link
Copy Markdown
Collaborator

Summary

Adds a borderRadius option to mention styles in both EnrichedTextInput and EnrichedText. It can be set per indicator like the other mention style properties:

htmlStyle={{
  mention: {
    '@': { backgroundColor: 'lightgreen', borderRadius: 6 },
  },
}}

Test Plan

  1. Run the example app (iOS, Android) and the web example.
  2. In the example htmlStyle / editorConfig, set borderRadius on the @ mention style (for example borderRadius: 6).

Screenshots / Videos

iOS Android Web
ios android web

Compatibility

OS Implemented
iOS ✅
Android ✅
Web ✅

Checklist

  • E2E tests are passing
  • Required E2E tests have been added (if applicable)

@relextm19
relextm19 marked this pull request as ready for review November 5, 2026 11:19
Copilot AI balanced review requested due to automatic review settings November 5, 2026 11:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@relextm19
relextm19 force-pushed the @relextm19/add-mention-border-radius branch from d21a1fd to a3a748d Compare November 5, 2026 11:23
@relextm19
relextm19 force-pushed the @relextm19/add-mention-border-radius branch from a3a748d to 7a13dc6 Compare November 5, 2026 11:23
Comment thread ios/styles/MentionStyle.mm Resolved
@szydlovsky
szydlovsky self-requested a review November 9, 2026 10:38
Comment thread ios/interfaces/MentionStyleProps.h Resolved
Comment thread ios/styles/MentionStyle.mm Resolved
@relextm19
relextm19 force-pushed the @relextm19/add-mention-border-radius branch from c0e19c8 to 43b7f88 Compare November 9, 2026 12:59
@relextm19
relextm19 force-pushed the @relextm19/add-mention-border-radius branch from 43b7f88 to a7aca8f Compare November 9, 2026 13:06

@szydlovsky szydlovsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS looks and works great now!

Comment thread src/types.ts Resolved
@relextm19
relextm19 force-pushed the @relextm19/add-mention-border-radius branch from 9fb3457 to 4633946 Compare November 10, 2026 10:50
@szydlovsky
szydlovsky merged commit 4d0552f into main Nov 12, 2026
9 checks passed
@szydlovsky
szydlovsky deleted the @relextm19/add-mention-border-radius branch November 12, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants