Repository navigation
ci(journeys): start the journeys jobs after the site job again - #564
Merged
Merged
Conversation
The journeys jobs have started with the rest of the run since #530, and polled the jobs API until the site job was done. When several runs share the 20 runners, the site job waits in the queue too, often longer than its journeys jobs, which then hold five runners doing nothing: up to 34 runner-minutes in one run, when other pull requests' jobs are waiting for a runner. The overlap saves about a minute only when the run has runners to spare. The jobs need the site job again, so a failed site job skips them through needs, which ci-ok already fails on. The wait step goes, and with it the actions: read permission only it used; the timeout goes back to the journeys' own 25 minutes. The server still starts while the browsers are set up, and #530's other changes stay. Closes: #561
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Since #530, the journeys jobs have started with the rest of the run and polled the jobs API until the site job was done. When several runs share the 20 runners, the site job waits in the queue too, often longer than its journeys jobs. Those jobs then hold five runners doing nothing, while other pull requests' jobs wait for one. In run 41785995461 they spent 2042 s waiting (34 runner-minutes), and in other busy runs 482–868 s. The overlap saves about a minute, but only when the run has runners to spare.
needs: [gate, site]). A failed site job skips them, and ci-ok already fails then.fail-fast-journeysfires only on a failure, so it doesn't fire on a skip.journeys-reportstill passes with no report, as it did before The journeys keep a run waiting 9–13 minutes and flash through every theme after each step #530.permissions:block. The block held only the workflow's defaultcontents: readand theactions: readthat the wait used.The cost: when the run has runners to spare and
checkhits Turbo's cache, the journeys are the run's last jobs, and that run ends about a minute later. Whencheckruns its tasks, it ends after the journeys anyway.Closes: #561