Repository navigation
fix(solid): name an instance whose folder does not decode as written - #566
Merged
Merged
Conversation
ixuz
marked this pull request as draft
November 4, 2026 16:10
An instance registration with no title is named after its folder, and that name was decoded with decodeURIComponent, which throws on a lone percent sign, a non-hex escape or bytes that are not UTF-8, such as a Latin-1 folder name another app wrote as caf%E9. The address check accepts such addresses, so one registration like that in a type index made the whole instance list fail, and the workspace could not open until the registration was removed by hand. Adding such a folder by its address failed the same way. lastPathSegment now returns the segment as written when it does not decode, and listInstances leaves out a registration that cannot be read as an instance instead of failing the list with it. Refs: GHSA-4mmj-5fv6-9jjf
ixuz
force-pushed
the
fix/instance-name-bad-escape
branch
from
November 4, 2026 17:11
f26bfd4 to
0ec77ab
Compare
ixuz
marked this pull request as ready for review
November 4, 2026 17:17
ixuz
enabled auto-merge
November 4, 2026 17:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
An instance registration with no title is named after its folder, and that name was decoded with
decodeURIComponent. That throws on a lone percent sign, a non-hex escape, or bytes that are not UTF-8, such as a Latin-1 folder name another app wrote ascaf%E9. The address check accepts such addresses, so one registration like that in a type index made the whole instance list fail. The workspace could not open until the registration was removed by hand. Adding such a folder by its address failed the same way.lastPathSegment(packages/solid/src/urls.ts) returns the segment as written when it does not decode.listInstancesleaves out a registration that cannot be read as an instance, and the rest of the list still loads.decodeURI/decodeURIComponentcalls on pod or link text already catch a failed decode.%E9, a lone%and%ZZin the last segment, and one bad registration among good ones.docs/data-model.md.Refs: GHSA-4mmj-5fv6-9jjf