Repository navigation
fix: leave out errors thrown by browser extensions - #46
Merged
Merged
Conversation
An extension's content script runs in the page, so its errors reach the window's error and unhandledrejection events and were listed as the app's. An error is now skipped when its event names an extension file, or when the first frame of its stack is in one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A browser extension's content script runs in the page, so its errors reach the window's
errorandunhandledrejectionevents. The toolbar listed them as the app's errors and opened the dock on them. While testing #45 in Chrome, an extension added over 160TypeError: Cannot read properties of undefined (reading 'M_ID')errors fromchrome-extension://…/executors/200.js.Changes
src/dev-toolbar/extension-errors.ts:isExtensionError(error, filename?)is true when the event names a file from an extension, or when the first frame of the stack is in one. It covers thechrome-extension://,moz-extension://,safari-web-extension://andms-browser-extension://schemes.errorandunhandledrejectionhandlers skip those errors.Proof
ErrorEventand an extension rejection. It fails onmain, where the dock opens on the error, and passes here. It also checks that an app error still opens the Errors tab.pnpm format:check,pnpm typecheck,pnpm build,pnpm testandpnpm test:e2e(24 tests) pass.Risk
Review
src/dev-toolbar/index.tsx, so whichever merges second needs a small rebase.🤖 Generated with Claude Code