Repository navigation
refactor: drop the recorded client outDir now that app builds read memory - #519
Merged
Merged
Conversation
…mory Since #514 and #518, a server build in the same process as the client build reads the build id, the server-function modules and Vite's manifest from memory. The recorded client output directory could then only lead to a stale file, so readers fall back to the configured outDir and the dist/client convention only.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #514 and #518, a server build in the same process as the client build reads the build id, server-function modules and Vite's manifest from memory, so the client output directory recorded for that case was never read. Removing it leaves the configured
outDirand thedist/clientconvention for separatevite build --ssrruns. No behavior change.